Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should see a loading screen instead of the default values for the screens #83

Open
nashirj opened this issue Dec 1, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request urgent

Comments

@nashirj
Copy link
Member

nashirj commented Dec 1, 2020

On screens where fields are populated after a network request is made, the user should not see the default values. Maybe ask in iOS help about this?

@nashirj nashirj added this to the Sprint 3 milestone Dec 1, 2020
@nashirj nashirj self-assigned this Dec 1, 2020
@nashirj
Copy link
Member Author

nashirj commented Dec 4, 2020

Maybe a loading spinner or something

@nashirj nashirj added the enhancement New feature or request label Dec 5, 2020
@nashirj nashirj assigned nashirj and unassigned nashirj Dec 5, 2020
@nashirj nashirj added the urgent label Dec 7, 2020
@nashirj nashirj assigned tahaafzal5 and unassigned nashirj Dec 8, 2020
@tahaafzal5
Copy link
Collaborator

tahaafzal5 commented Dec 10, 2020

@nashirj I am having trouble making the loading indication work for the tableView when going to the ProfileView and the AccountDetailsView.

How the loading indicator works for when I navigate to the RideDetails:
I call self.showSpinner(onView: self.view) when the view is loading to display the indicator. When everything has appeared, I call self.removeSpinner() to remove the indicator from the screen.

Issue on tableViews:
The issue, in my understanding is this: even though there is a way to check if all the cells in the tableView have loaded, I could not find a way to check if they all are displayed. So I can show the indictor, but not find the spot when the tableView has completed displaying data for me to remove the indicator.

Look at my branch issue_83 and lmk if you find a way to do it. We can discuss further too if needed.

@nashirj
Copy link
Member Author

nashirj commented Dec 11, 2020

check this out, seems like it might be useful: https://stackoverflow.com/questions/4163579/how-to-detect-the-end-of-loading-of-uitableview

are you saying though that this isn't giving you enough information? like the cells are loaded but not yet displayed?

@nashirj
Copy link
Member Author

nashirj commented Dec 12, 2020

Done for now, need to revisit later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request urgent
Projects
None yet
Development

No branches or pull requests

2 participants