diff --git a/scripts/tests/data/foo.almost.cpp b/scripts/tests/data/foo.almost.cpp index 2804910f6e73..e0d9ceefb65c 100644 --- a/scripts/tests/data/foo.almost.cpp +++ b/scripts/tests/data/foo.almost.cpp @@ -14,12 +14,12 @@ */ import argparse import fnmatch import os import regex import sys - class attrdict(dict) : __getattr__ = dict.__getitem__ __setattr__ = dict.__setitem__ + class attrdict(dict) :__getattr__ = dict.__getitem__ __setattr__ = dict.__setitem__ - def parse_args() : parser = argparse.ArgumentParser(description = 'Update license headers') parser.add_argument('--header', default = 'license.header', help = 'header file') parser.add_argument('--extra', default = 30, help = 'extra characters past beginning of file to look for header') parser.add_argument('--editdist', default = 7, help = 'max edit distance between headers') parser.add_argument('--remove', default = False, action = "store_true", help = 'remove the header') parser.add_argument('--cslash', default = False, action = "store_true", help = 'use C slash "//" style comments') parser.add_argument('-v', default = False, action = "store_true", dest = "verbose", help = 'verbose output') + def parse_args() :parser = argparse.ArgumentParser(description = 'Update license headers') parser.add_argument('--header', default = 'license.header', help = 'header file') parser.add_argument('--extra', default = 30, help = 'extra characters past beginning of file to look for header') parser.add_argument('--editdist', default = 7, help = 'max edit distance between headers') parser.add_argument('--remove', default = False, action = "store_true", help = 'remove the header') parser.add_argument('--cslash', default = False, action = "store_true", help = 'use C slash "//" style comments') parser.add_argument('-v', default = False, action = "store_true", dest = "verbose", help = 'verbose output') - group = parser.add_mutually_exclusive_group() group.add_argument('-k', default = False, action = "store_true", dest = "check", help = 'check headers') group.add_argument('-i', default = False, action = "store_true", dest = "inplace", help = 'edit file inplace') + group = parser.add_mutually_exclusive_group() group.add_argument('-k', default = False, action = "store_true", dest = "check", help = 'check headers') group.add_argument('-i', default = False, action = "store_true", dest = "inplace", help = 'edit file inplace') - parser.add_argument('files', metavar = 'FILES', nargs = '+', help = 'files to process') + parser.add_argument('files', metavar = 'FILES', nargs = '+', help = 'files to process') - return parser.parse_args() + return parser.parse_args() diff --git a/scripts/tests/data/foo.cpp b/scripts/tests/data/foo.cpp index f4f78dfbffbe..d631de2ff2e1 100644 --- a/scripts/tests/data/foo.cpp +++ b/scripts/tests/data/foo.cpp @@ -1,11 +1,11 @@ import argparse import fnmatch import os import regex import sys - class attrdict(dict) : __getattr__ = dict.__getitem__ __setattr__ = dict.__setitem__ + class attrdict(dict) :__getattr__ = dict.__getitem__ __setattr__ = dict.__setitem__ - def parse_args() : parser = argparse.ArgumentParser(description = 'Update license headers') parser.add_argument('--header', default = 'license.header', help = 'header file') parser.add_argument('--extra', default = 30, help = 'extra characters past beginning of file to look for header') parser.add_argument('--editdist', default = 7, help = 'max edit distance between headers') parser.add_argument('--remove', default = False, action = "store_true", help = 'remove the header') parser.add_argument('--cslash', default = False, action = "store_true", help = 'use C slash "//" style comments') parser.add_argument('-v', default = False, action = "store_true", dest = "verbose", help = 'verbose output') + def parse_args() :parser = argparse.ArgumentParser(description = 'Update license headers') parser.add_argument('--header', default = 'license.header', help = 'header file') parser.add_argument('--extra', default = 30, help = 'extra characters past beginning of file to look for header') parser.add_argument('--editdist', default = 7, help = 'max edit distance between headers') parser.add_argument('--remove', default = False, action = "store_true", help = 'remove the header') parser.add_argument('--cslash', default = False, action = "store_true", help = 'use C slash "//" style comments') parser.add_argument('-v', default = False, action = "store_true", dest = "verbose", help = 'verbose output') - group = parser.add_mutually_exclusive_group() group.add_argument('-k', default = False, action = "store_true", dest = "check", help = 'check headers') group.add_argument('-i', default = False, action = "store_true", dest = "inplace", help = 'edit file inplace') + group = parser.add_mutually_exclusive_group() group.add_argument('-k', default = False, action = "store_true", dest = "check", help = 'check headers') group.add_argument('-i', default = False, action = "store_true", dest = "inplace", help = 'edit file inplace') - parser.add_argument('files', metavar = 'FILES', nargs = '+', help = 'files to process') + parser.add_argument('files', metavar = 'FILES', nargs = '+', help = 'files to process') - return parser.parse_args() + return parser.parse_args() diff --git a/scripts/tests/data/foo.expected.cpp b/scripts/tests/data/foo.expected.cpp index e3f75b39c6a5..31b2bce9b283 100644 --- a/scripts/tests/data/foo.expected.cpp +++ b/scripts/tests/data/foo.expected.cpp @@ -13,12 +13,12 @@ */ import argparse import fnmatch import os import regex import sys - class attrdict(dict) : __getattr__ = dict.__getitem__ __setattr__ = dict.__setitem__ + class attrdict(dict) :__getattr__ = dict.__getitem__ __setattr__ = dict.__setitem__ - def parse_args() : parser = argparse.ArgumentParser(description = 'Update license headers') parser.add_argument('--header', default = 'license.header', help = 'header file') parser.add_argument('--extra', default = 30, help = 'extra characters past beginning of file to look for header') parser.add_argument('--editdist', default = 7, help = 'max edit distance between headers') parser.add_argument('--remove', default = False, action = "store_true", help = 'remove the header') parser.add_argument('--cslash', default = False, action = "store_true", help = 'use C slash "//" style comments') parser.add_argument('-v', default = False, action = "store_true", dest = "verbose", help = 'verbose output') + def parse_args() :parser = argparse.ArgumentParser(description = 'Update license headers') parser.add_argument('--header', default = 'license.header', help = 'header file') parser.add_argument('--extra', default = 30, help = 'extra characters past beginning of file to look for header') parser.add_argument('--editdist', default = 7, help = 'max edit distance between headers') parser.add_argument('--remove', default = False, action = "store_true", help = 'remove the header') parser.add_argument('--cslash', default = False, action = "store_true", help = 'use C slash "//" style comments') parser.add_argument('-v', default = False, action = "store_true", dest = "verbose", help = 'verbose output') - group = parser.add_mutually_exclusive_group() group.add_argument('-k', default = False, action = "store_true", dest = "check", help = 'check headers') group.add_argument('-i', default = False, action = "store_true", dest = "inplace", help = 'edit file inplace') + group = parser.add_mutually_exclusive_group() group.add_argument('-k', default = False, action = "store_true", dest = "check", help = 'check headers') group.add_argument('-i', default = False, action = "store_true", dest = "inplace", help = 'edit file inplace') - parser.add_argument('files', metavar = 'FILES', nargs = '+', help = 'files to process') + parser.add_argument('files', metavar = 'FILES', nargs = '+', help = 'files to process') - return parser.parse_args() + return parser.parse_args() diff --git a/scripts/tests/data/foo.expected.h b/scripts/tests/data/foo.expected.h index e3f75b39c6a5..31b2bce9b283 100644 --- a/scripts/tests/data/foo.expected.h +++ b/scripts/tests/data/foo.expected.h @@ -13,12 +13,12 @@ */ import argparse import fnmatch import os import regex import sys - class attrdict(dict) : __getattr__ = dict.__getitem__ __setattr__ = dict.__setitem__ + class attrdict(dict) :__getattr__ = dict.__getitem__ __setattr__ = dict.__setitem__ - def parse_args() : parser = argparse.ArgumentParser(description = 'Update license headers') parser.add_argument('--header', default = 'license.header', help = 'header file') parser.add_argument('--extra', default = 30, help = 'extra characters past beginning of file to look for header') parser.add_argument('--editdist', default = 7, help = 'max edit distance between headers') parser.add_argument('--remove', default = False, action = "store_true", help = 'remove the header') parser.add_argument('--cslash', default = False, action = "store_true", help = 'use C slash "//" style comments') parser.add_argument('-v', default = False, action = "store_true", dest = "verbose", help = 'verbose output') + def parse_args() :parser = argparse.ArgumentParser(description = 'Update license headers') parser.add_argument('--header', default = 'license.header', help = 'header file') parser.add_argument('--extra', default = 30, help = 'extra characters past beginning of file to look for header') parser.add_argument('--editdist', default = 7, help = 'max edit distance between headers') parser.add_argument('--remove', default = False, action = "store_true", help = 'remove the header') parser.add_argument('--cslash', default = False, action = "store_true", help = 'use C slash "//" style comments') parser.add_argument('-v', default = False, action = "store_true", dest = "verbose", help = 'verbose output') - group = parser.add_mutually_exclusive_group() group.add_argument('-k', default = False, action = "store_true", dest = "check", help = 'check headers') group.add_argument('-i', default = False, action = "store_true", dest = "inplace", help = 'edit file inplace') + group = parser.add_mutually_exclusive_group() group.add_argument('-k', default = False, action = "store_true", dest = "check", help = 'check headers') group.add_argument('-i', default = False, action = "store_true", dest = "inplace", help = 'edit file inplace') - parser.add_argument('files', metavar = 'FILES', nargs = '+', help = 'files to process') + parser.add_argument('files', metavar = 'FILES', nargs = '+', help = 'files to process') - return parser.parse_args() + return parser.parse_args() diff --git a/scripts/tests/data/foo.h b/scripts/tests/data/foo.h index f4f78dfbffbe..d631de2ff2e1 100644 --- a/scripts/tests/data/foo.h +++ b/scripts/tests/data/foo.h @@ -1,11 +1,11 @@ import argparse import fnmatch import os import regex import sys - class attrdict(dict) : __getattr__ = dict.__getitem__ __setattr__ = dict.__setitem__ + class attrdict(dict) :__getattr__ = dict.__getitem__ __setattr__ = dict.__setitem__ - def parse_args() : parser = argparse.ArgumentParser(description = 'Update license headers') parser.add_argument('--header', default = 'license.header', help = 'header file') parser.add_argument('--extra', default = 30, help = 'extra characters past beginning of file to look for header') parser.add_argument('--editdist', default = 7, help = 'max edit distance between headers') parser.add_argument('--remove', default = False, action = "store_true", help = 'remove the header') parser.add_argument('--cslash', default = False, action = "store_true", help = 'use C slash "//" style comments') parser.add_argument('-v', default = False, action = "store_true", dest = "verbose", help = 'verbose output') + def parse_args() :parser = argparse.ArgumentParser(description = 'Update license headers') parser.add_argument('--header', default = 'license.header', help = 'header file') parser.add_argument('--extra', default = 30, help = 'extra characters past beginning of file to look for header') parser.add_argument('--editdist', default = 7, help = 'max edit distance between headers') parser.add_argument('--remove', default = False, action = "store_true", help = 'remove the header') parser.add_argument('--cslash', default = False, action = "store_true", help = 'use C slash "//" style comments') parser.add_argument('-v', default = False, action = "store_true", dest = "verbose", help = 'verbose output') - group = parser.add_mutually_exclusive_group() group.add_argument('-k', default = False, action = "store_true", dest = "check", help = 'check headers') group.add_argument('-i', default = False, action = "store_true", dest = "inplace", help = 'edit file inplace') + group = parser.add_mutually_exclusive_group() group.add_argument('-k', default = False, action = "store_true", dest = "check", help = 'check headers') group.add_argument('-i', default = False, action = "store_true", dest = "inplace", help = 'edit file inplace') - parser.add_argument('files', metavar = 'FILES', nargs = '+', help = 'files to process') + parser.add_argument('files', metavar = 'FILES', nargs = '+', help = 'files to process') - return parser.parse_args() + return parser.parse_args() diff --git a/velox/buffer/Buffer.h b/velox/buffer/Buffer.h index 38c3c7cc0898..14ae371c7142 100644 --- a/velox/buffer/Buffer.h +++ b/velox/buffer/Buffer.h @@ -56,7 +56,7 @@ class Buffer { // and trivially copyable (so memcpy works) template static inline constexpr bool is_pod_like_v = - std::is_trivially_destructible_v&& std::is_trivially_copyable_v; + std::is_trivially_destructible_v && std::is_trivially_copyable_v; virtual ~Buffer() {} diff --git a/velox/common/file/tests/FileTest.cpp b/velox/common/file/tests/FileTest.cpp index 9f837fc94a23..eedb2a6808ee 100644 --- a/velox/common/file/tests/FileTest.cpp +++ b/velox/common/file/tests/FileTest.cpp @@ -78,7 +78,8 @@ void readData(ReadFile* readFile, bool checkFileSize = true) { folly::Range(middle, sizeof(middle)), folly::Range( nullptr, - (char*)(uint64_t)(15 + kOneMB - 500000 - sizeof(head) - sizeof(middle) - sizeof(tail))), + (char*)(uint64_t)(15 + kOneMB - 500000 - sizeof(head) - + sizeof(middle) - sizeof(tail))), folly::Range(tail, sizeof(tail))}; ASSERT_EQ(15 + kOneMB, readFile->preadv(0, buffers)); ASSERT_EQ(std::string_view(head, sizeof(head)), "aaaaabbbbbcc"); diff --git a/velox/connectors/hive/storage_adapters/s3fs/tests/S3Test.h b/velox/connectors/hive/storage_adapters/s3fs/tests/S3Test.h index e49a8c42d45e..f89f40959365 100644 --- a/velox/connectors/hive/storage_adapters/s3fs/tests/S3Test.h +++ b/velox/connectors/hive/storage_adapters/s3fs/tests/S3Test.h @@ -90,7 +90,8 @@ class S3Test : public testing::Test, public ::test::VectorTestBase { folly::Range(middle, sizeof(middle)), folly::Range( nullptr, - (char*)(uint64_t)(15 + kOneMB - 500000 - sizeof(head) - sizeof(middle) - sizeof(tail))), + (char*)(uint64_t)(15 + kOneMB - 500000 - sizeof(head) - + sizeof(middle) - sizeof(tail))), folly::Range(tail, sizeof(tail))}; ASSERT_EQ(15 + kOneMB, readFile->preadv(0, buffers)); ASSERT_EQ(std::string_view(head, sizeof(head)), "aaaaabbbbbcc"); diff --git a/velox/connectors/hive/tests/HiveDataSinkTest.cpp b/velox/connectors/hive/tests/HiveDataSinkTest.cpp index 7ee1e3a065dd..3d16da4744f7 100644 --- a/velox/connectors/hive/tests/HiveDataSinkTest.cpp +++ b/velox/connectors/hive/tests/HiveDataSinkTest.cpp @@ -591,14 +591,14 @@ TEST_F(HiveDataSinkTest, memoryReclaim) { expectedWriterReclaimed); } } testSettings[] = { - // {dwio::common::FileFormat::DWRF, true, true, 1 << 30, true, true}, - {dwio::common::FileFormat::DWRF, true, true, 1, true, true}, - {dwio::common::FileFormat::DWRF, true, false, 1 << 30, false, false}, - {dwio::common::FileFormat::DWRF, true, false, 1, false, false}, - {dwio::common::FileFormat::DWRF, false, true, 1 << 30, true, false}, - {dwio::common::FileFormat::DWRF, false, true, 1, true, true}, - {dwio::common::FileFormat::DWRF, false, false, 1 << 30, false, false}, - {dwio::common::FileFormat::DWRF, false, false, 1, false, false}, + // {dwio::common::FileFormat::DWRF, true, true, 1 << 30, true, true}, + {dwio::common::FileFormat::DWRF, true, true, 1, true, true}, + {dwio::common::FileFormat::DWRF, true, false, 1 << 30, false, false}, + {dwio::common::FileFormat::DWRF, true, false, 1, false, false}, + {dwio::common::FileFormat::DWRF, false, true, 1 << 30, true, false}, + {dwio::common::FileFormat::DWRF, false, true, 1, true, true}, + {dwio::common::FileFormat::DWRF, false, false, 1 << 30, false, false}, + {dwio::common::FileFormat::DWRF, false, false, 1, false, false}, // Add Parquet with https://github.com/facebookincubator/velox/issues/5560 #if 0 {dwio::common::FileFormat::PARQUET, true, true, 1 << 30, false, false}, diff --git a/velox/core/Metaprogramming.h b/velox/core/Metaprogramming.h index d50a15393250..317837bfb98a 100644 --- a/velox/core/Metaprogramming.h +++ b/velox/core/Metaprogramming.h @@ -124,10 +124,11 @@ template struct has_method { private: template - static constexpr auto check(T*) -> typename std::is_same< - decltype(std::declval().template resolve( - std::declval()...)), - TRet>::type { + static constexpr auto check(T*) -> + typename std::is_same< + decltype(std::declval().template resolve( + std::declval()...)), + TRet>::type { return {}; } diff --git a/velox/dwio/common/DecoderUtil.h b/velox/dwio/common/DecoderUtil.h index dd393e452b7a..015350ae2666 100644 --- a/velox/dwio/common/DecoderUtil.h +++ b/velox/dwio/common/DecoderUtil.h @@ -391,9 +391,9 @@ bool nonNullRowsFromSparse( // See SelectiveColumnReader::useBulkPath. template bool useFastPath(Visitor& visitor) { - return (!std::is_same_v)&&process:: - hasAvx2() && - Visitor::FilterType::deterministic && Visitor::kHasBulkPath && + return (!std::is_same_v) && + process::hasAvx2() && Visitor::FilterType::deterministic && + Visitor::kHasBulkPath && (std:: is_same_v || !hasNulls || !visitor.allowNulls()) && diff --git a/velox/dwio/dwrf/test/E2EFilterTest.cpp b/velox/dwio/dwrf/test/E2EFilterTest.cpp index 3f397e04d97f..50c78e37c76e 100644 --- a/velox/dwio/dwrf/test/E2EFilterTest.cpp +++ b/velox/dwio/dwrf/test/E2EFilterTest.cpp @@ -387,8 +387,7 @@ TEST_F(E2EFilterTest, flatMapAsStruct) { "long_vals:struct," "struct_vals:struct,nested2:struct>"; flatMapColumns_ = {"long_vals", "struct_vals"}; - testWithTypes( - kColumns, [] {}, false, {"long_val"}, 10, true); + testWithTypes(kColumns, [] {}, false, {"long_val"}, 10, true); } TEST_F(E2EFilterTest, flatMapScalar) { diff --git a/velox/dwio/parquet/writer/arrow/LevelComparison.cpp b/velox/dwio/parquet/writer/arrow/LevelComparison.cpp index 1f4fef6e187a..18ac0ca81a45 100644 --- a/velox/dwio/parquet/writer/arrow/LevelComparison.cpp +++ b/velox/dwio/parquet/writer/arrow/LevelComparison.cpp @@ -46,11 +46,10 @@ struct GreaterThanDynamicFunction { static std::vector> implementations() { return { - { DispatchLevel::NONE, standard::GreaterThanBitmapImpl } + {DispatchLevel::NONE, standard::GreaterThanBitmapImpl} #if defined(ARROW_HAVE_RUNTIME_AVX2) - , { - DispatchLevel::AVX2, GreaterThanBitmapAvx2 - } + , + {DispatchLevel::AVX2, GreaterThanBitmapAvx2} #endif }; } @@ -61,11 +60,10 @@ struct MinMaxDynamicFunction { static std::vector> implementations() { return { - { DispatchLevel::NONE, standard::FindMinMaxImpl } + {DispatchLevel::NONE, standard::FindMinMaxImpl} #if defined(ARROW_HAVE_RUNTIME_AVX2) - , { - DispatchLevel::AVX2, FindMinMaxAvx2 - } + , + {DispatchLevel::AVX2, FindMinMaxAvx2} #endif }; } diff --git a/velox/dwio/parquet/writer/arrow/Schema.cpp b/velox/dwio/parquet/writer/arrow/Schema.cpp index 0ef01a6272d5..a333044e701a 100644 --- a/velox/dwio/parquet/writer/arrow/Schema.cpp +++ b/velox/dwio/parquet/writer/arrow/Schema.cpp @@ -785,8 +785,8 @@ struct SchemaPrinter : public Node::ConstVisitor { void Visit(const GroupNode* node) { PrintRepLevel(node->repetition(), stream_); - stream_ << " group " - << "field_id=" << node->field_id() << " " << node->name(); + stream_ << " group " << "field_id=" << node->field_id() << " " + << node->name(); auto lt = node->converted_type(); auto la = node->logical_type(); if (la && la->is_valid() && !la->is_none()) { diff --git a/velox/dwio/parquet/writer/arrow/util/safe-math.h b/velox/dwio/parquet/writer/arrow/util/safe-math.h index d851546512fc..255579909984 100644 --- a/velox/dwio/parquet/writer/arrow/util/safe-math.h +++ b/velox/dwio/parquet/writer/arrow/util/safe-math.h @@ -1312,18 +1312,19 @@ PSNIP_SAFE_DEFINE_UNSIGNED_MOD(psnip_uint64_t, uint64, 0xffffffffffffffffULL) #endif /* !defined(PSNIP_SAFE_NO_FIXED) */ -#define PSNIP_SAFE_C11_GENERIC_SELECTION(res, op) \ - _Generic((*res), char \ - : psnip_safe_char_##op, unsigned char \ - : psnip_safe_uchar_##op, short \ - : psnip_safe_short_##op, unsigned short \ - : psnip_safe_ushort_##op, int \ - : psnip_safe_int_##op, unsigned int \ - : psnip_safe_uint_##op, long \ - : psnip_safe_long_##op, unsigned long \ - : psnip_safe_ulong_##op, long long \ - : psnip_safe_llong_##op, unsigned long long \ - : psnip_safe_ullong_##op) +#define PSNIP_SAFE_C11_GENERIC_SELECTION(res, op) \ + _Generic( \ + (*res), \ + char: psnip_safe_char_##op, \ + unsigned char: psnip_safe_uchar_##op, \ + short: psnip_safe_short_##op, \ + unsigned short: psnip_safe_ushort_##op, \ + int: psnip_safe_int_##op, \ + unsigned int: psnip_safe_uint_##op, \ + long: psnip_safe_long_##op, \ + unsigned long: psnip_safe_ulong_##op, \ + long long: psnip_safe_llong_##op, \ + unsigned long long: psnip_safe_ullong_##op) #define PSNIP_SAFE_C11_GENERIC_BINARY_OP(op, res, a, b) \ PSNIP_SAFE_C11_GENERIC_SELECTION(res, op)(res, a, b) diff --git a/velox/exec/OutputBuffer.cpp b/velox/exec/OutputBuffer.cpp index 1ce94a89700f..f771fbebc5d8 100644 --- a/velox/exec/OutputBuffer.cpp +++ b/velox/exec/OutputBuffer.cpp @@ -302,9 +302,8 @@ DestinationBuffer::Stats DestinationBuffer::stats() const { std::string DestinationBuffer::toString() { std::stringstream out; - out << "[available: " << data_.size() << ", " - << "sequence: " << sequence_ << ", " - << (notify_ ? "notify registered, " : "") << this << "]"; + out << "[available: " << data_.size() << ", " << "sequence: " << sequence_ + << ", " << (notify_ ? "notify registered, " : "") << this << "]"; return out.str(); } diff --git a/velox/exec/tests/LocalPartitionTest.cpp b/velox/exec/tests/LocalPartitionTest.cpp index 86549b636a5a..78ae9cf775ee 100644 --- a/velox/exec/tests/LocalPartitionTest.cpp +++ b/velox/exec/tests/LocalPartitionTest.cpp @@ -559,8 +559,7 @@ TEST_F(LocalPartitionTest, producerError) { const auto& task = cursor->task(); // Expect division by zero error. - ASSERT_THROW( - while (cursor->moveNext()) { ; }, VeloxException); + ASSERT_THROW(while (cursor->moveNext()) { ; }, VeloxException); // Wait for task to transition to failed state. waitForTaskCompletion(task, exec::kFailed); diff --git a/velox/exec/tests/OutputBufferManagerTest.cpp b/velox/exec/tests/OutputBufferManagerTest.cpp index 356b92089c68..97053d5bf072 100644 --- a/velox/exec/tests/OutputBufferManagerTest.cpp +++ b/velox/exec/tests/OutputBufferManagerTest.cpp @@ -717,8 +717,8 @@ TEST_F(OutputBufferManagerTest, destinationBuffer) { buffer.enqueue(makeSerializedPage(rowType_, 100)); } DestinationBuffer destinationBuffer; - auto buffers = destinationBuffer.getData( - 1, 0, noNotify, [] { return true; }, &buffer); + auto buffers = + destinationBuffer.getData(1, 0, noNotify, [] { return true; }, &buffer); ASSERT_TRUE(buffers.immediate); ASSERT_EQ(buffers.data.size(), 1); ASSERT_GT(buffers.data[0]->length(), 0); diff --git a/velox/exec/tests/PrintPlanWithStatsTest.cpp b/velox/exec/tests/PrintPlanWithStatsTest.cpp index 39f1bfdd44b1..a13fdcd09f94 100644 --- a/velox/exec/tests/PrintPlanWithStatsTest.cpp +++ b/velox/exec/tests/PrintPlanWithStatsTest.cpp @@ -50,8 +50,7 @@ void compareOutputs( while (!RE2::FullMatch(line, expectedLine.line)) { potentialLines.push_back(expectedLine.line); if (!expectedLine.optional) { - ASSERT_FALSE(true) << "Output did not match " - << "Source:" << testName + ASSERT_FALSE(true) << "Output did not match " << "Source:" << testName << ", Line number:" << lineCount << ", Line: " << line << ", Expected Line one of: " << folly::join(",", potentialLines); diff --git a/velox/experimental/gpu/tests/BlockingQueueTest.cu b/velox/experimental/gpu/tests/BlockingQueueTest.cu index 3e59c2e2d6b8..e655180c35f2 100644 --- a/velox/experimental/gpu/tests/BlockingQueueTest.cu +++ b/velox/experimental/gpu/tests/BlockingQueueTest.cu @@ -198,7 +198,9 @@ __global__ void runGpu2Gpu( cuda::atomic& nextId, int capacity, int limit) { - __shared__ struct { int64_t message; } shared; + __shared__ struct { + int64_t message; + } shared; if (blockIdx.x == 0) { nextId = 0; for (int i = 0; i < capacity; ++i) { diff --git a/velox/expression/ComplexViewTypes.h b/velox/expression/ComplexViewTypes.h index 1c96a98989b3..74709c578042 100644 --- a/velox/expression/ComplexViewTypes.h +++ b/velox/expression/ComplexViewTypes.h @@ -1134,8 +1134,7 @@ class GenericView { // castReaders_[0], and is set in Vector readers. if constexpr (SimpleTypeTrait::isPrimitiveType) { return reinterpret_cast*>(castReaders_[0].get()) - -> - operator[](index_); + ->operator[](index_); } else { // TODO: We can distinguish if this is a null-free or not null-free // generic. And based on that determine if we want to call operator[] or diff --git a/velox/expression/ConjunctExpr.cpp b/velox/expression/ConjunctExpr.cpp index b3ac9f552f16..a82017175167 100644 --- a/velox/expression/ConjunctExpr.cpp +++ b/velox/expression/ConjunctExpr.cpp @@ -389,8 +389,8 @@ std::string ConjunctExpr::toSql( std::stringstream out; out << "(" << inputs_[0]->toSql(complexConstants) << ")"; for (auto i = 1; i < inputs_.size(); ++i) { - out << " " << name_ << " " - << "(" << inputs_[i]->toSql(complexConstants) << ")"; + out << " " << name_ << " " << "(" << inputs_[i]->toSql(complexConstants) + << ")"; } return out.str(); } diff --git a/velox/expression/SimpleFunctionAdapter.h b/velox/expression/SimpleFunctionAdapter.h index 7f55d7d7f64f..b6b0aae5f59c 100644 --- a/velox/expression/SimpleFunctionAdapter.h +++ b/velox/expression/SimpleFunctionAdapter.h @@ -85,8 +85,8 @@ class SimpleFunctionAdapter : public VectorFunction { // boolean. template static constexpr bool isArgFlatConstantFastPathEligible = - SimpleTypeTrait>::isPrimitiveType&& - SimpleTypeTrait>::typeKind != TypeKind::BOOLEAN; + SimpleTypeTrait>::isPrimitiveType && + SimpleTypeTrait>::typeKind != TypeKind::BOOLEAN; constexpr int32_t reuseStringsFromArgValue() const { return udf_reuse_strings_from_arg(); @@ -249,8 +249,9 @@ class SimpleFunctionAdapter : public VectorFunction { template < int32_t POSITION, - typename std::enable_if_t = 0> - VectorPtr* findReusableArg(std::vector& args) const { + typename std::enable_if_t< + POSITION = 0> VectorPtr* + findReusableArg(std::vector& args) const { if constexpr (isVariadicType>::value) { if constexpr ( SimpleTypeTrait< diff --git a/velox/expression/tests/CastExprTest.cpp b/velox/expression/tests/CastExprTest.cpp index 25f904a08146..223e4678c722 100644 --- a/velox/expression/tests/CastExprTest.cpp +++ b/velox/expression/tests/CastExprTest.cpp @@ -2385,8 +2385,8 @@ class TestingDictionaryToFewerRowsFunction : public exec::VectorFunction { exec::EvalCtx& context, VectorPtr& result) const override { const auto size = rows.size(); - auto indices = makeIndices( - size, [](auto /*row*/) { return 0; }, context.pool()); + auto indices = + makeIndices(size, [](auto /*row*/) { return 0; }, context.pool()); result = BaseVector::wrapInDictionary(nullptr, indices, size, args[0]); } diff --git a/velox/expression/tests/ExprTest.cpp b/velox/expression/tests/ExprTest.cpp index c4df5aa14678..f08970adf0c8 100644 --- a/velox/expression/tests/ExprTest.cpp +++ b/velox/expression/tests/ExprTest.cpp @@ -770,8 +770,8 @@ TEST_P(ParameterizedExprTest, dictionaryAndConstantOverLazy) { auto row = makeRowVector({lazyVector}); auto result = evaluate("plus5(c0)", row); - auto expected = makeFlatVector( - size, [](auto row) { return row + 5; }, isNullAt); + auto expected = + makeFlatVector(size, [](auto row) { return row + 5; }, isNullAt); assertEqualVectors(expected, result); // Wrap LazyVector in a dictionary (select only even rows). @@ -1164,8 +1164,8 @@ TEST_P(ParameterizedExprTest, lazyVectors) { auto result = evaluate("c0 + coalesce(c0, 1)", row); - auto expected = makeFlatVector( - size, [](auto row) { return row * 2; }, nullptr); + auto expected = + makeFlatVector(size, [](auto row) { return row * 2; }, nullptr); assertEqualVectors(expected, result); // Make LazyVector with nulls @@ -1175,8 +1175,8 @@ TEST_P(ParameterizedExprTest, lazyVectors) { result = evaluate("c0 + coalesce(c0, 1)", row); - expected = makeFlatVector( - size, [](auto row) { return row * 2; }, isNullAt); + expected = + makeFlatVector(size, [](auto row) { return row * 2; }, isNullAt); assertEqualVectors(expected, result); } diff --git a/velox/functions/CoverageUtil.cpp b/velox/functions/CoverageUtil.cpp index b9877b4f0a71..9f941790bee7 100644 --- a/velox/functions/CoverageUtil.cpp +++ b/velox/functions/CoverageUtil.cpp @@ -49,10 +49,9 @@ class TablePrinter { columnSize_ * numScalarColumns_ + 2 * (numScalarColumns_ - 1); out_ << indent_ << std::left << std::setw(scalarFunctionsColumnWidth) - << "Scalar Functions" - << " " << std::setw(columnSize_) << "Aggregate Functions" - << " " - << "Window Functions" << std::endl; + << "Scalar Functions" << " " << std::setw(columnSize_) + << "Aggregate Functions" << " " << "Window Functions" + << std::endl; out_ << indent_ << std::string(scalarFunctionsColumnWidth, '=') << " == " << line << " == " << line << std::endl; } @@ -166,16 +165,13 @@ void printTableCss( out << " div.body {max-width: 1300px;}" << std::endl; out << " table.coverage th {background-color: lightblue; text-align: center;}" << std::endl; - out << " table.coverage " - << "td:nth-child(" << numScalarColumns + 1 << ") " - << "{background-color: lightblue;}" << std::endl; - out << " table.coverage " - << "td:nth-child(" << numScalarColumns + 3 << ") " - << "{background-color: lightblue;}" << std::endl; + out << " table.coverage " << "td:nth-child(" << numScalarColumns + 1 + << ") " << "{background-color: lightblue;}" << std::endl; + out << " table.coverage " << "td:nth-child(" << numScalarColumns + 3 + << ") " << "{background-color: lightblue;}" << std::endl; for (const auto& entry : cellTracker.cells()) { - out << " table.coverage " - << "tr:nth-child(" << entry.first + 1 << ") " + out << " table.coverage " << "tr:nth-child(" << entry.first + 1 << ") " << "td:nth-child(" << entry.second + 1 << ") " << "{background-color: #6BA81E;}" << std::endl; } diff --git a/velox/functions/prestosql/Arithmetic.h b/velox/functions/prestosql/Arithmetic.h index 5e2dfeb19836..85b5e86b4cd0 100644 --- a/velox/functions/prestosql/Arithmetic.h +++ b/velox/functions/prestosql/Arithmetic.h @@ -401,7 +401,8 @@ struct WidthBucketFunction { result = bucketCount + 1; } else { result = - (int64_t)((double)bucketCount * (operand - lower) / (upper - lower) + 1); + (int64_t)((double)bucketCount * (operand - lower) / (upper - lower) + + 1); } if (bound1 > bound2) { diff --git a/velox/functions/prestosql/aggregates/tests/ApproxDistinctTest.cpp b/velox/functions/prestosql/aggregates/tests/ApproxDistinctTest.cpp index 8db2126a2151..9bcae4d4a46b 100644 --- a/velox/functions/prestosql/aggregates/tests/ApproxDistinctTest.cpp +++ b/velox/functions/prestosql/aggregates/tests/ApproxDistinctTest.cpp @@ -301,8 +301,8 @@ TEST_F(ApproxDistinctTest, globalAggIntegersWithError) { TEST_F(ApproxDistinctTest, globalAggAllNulls) { vector_size_t size = 1'000; - auto values = makeFlatVector( - size, [](auto row) { return row; }, nullEvery(1)); + auto values = + makeFlatVector(size, [](auto row) { return row; }, nullEvery(1)); auto op = PlanBuilder() .values({makeRowVector({values})}) diff --git a/velox/functions/prestosql/aggregates/tests/HistogramTest.cpp b/velox/functions/prestosql/aggregates/tests/HistogramTest.cpp index b2a2c089cdea..f06f7d82a085 100644 --- a/velox/functions/prestosql/aggregates/tests/HistogramTest.cpp +++ b/velox/functions/prestosql/aggregates/tests/HistogramTest.cpp @@ -148,9 +148,7 @@ TEST_F(HistogramTest, groupByTimestamp) { num, [](vector_size_t row) { return row % 3; }, nullEvery(4)); auto vector2 = makeFlatVector( num, - [](vector_size_t row) { - return Timestamp{row % 2, 17'123'456}; - }, + [](vector_size_t row) { return Timestamp{row % 2, 17'123'456}; }, nullEvery(5)); auto expected = makeRowVector( @@ -237,9 +235,7 @@ TEST_F(HistogramTest, globalTimestamp) { vector_size_t num = 10; auto vector = makeFlatVector( num, - [](vector_size_t row) { - return Timestamp{row % 4, 100}; - }, + [](vector_size_t row) { return Timestamp{row % 4, 100}; }, nullEvery(7)); auto expected = makeRowVector({makeMapVector( diff --git a/velox/functions/prestosql/benchmarks/WidthBucketBenchmark.cpp b/velox/functions/prestosql/benchmarks/WidthBucketBenchmark.cpp index 4aeb355c9c2b..8a9bbcaad40e 100644 --- a/velox/functions/prestosql/benchmarks/WidthBucketBenchmark.cpp +++ b/velox/functions/prestosql/benchmarks/WidthBucketBenchmark.cpp @@ -44,7 +44,8 @@ struct WidthBucketFunction { result = bucketCount + 1; } else { result = - (int64_t)((double)bucketCount * (operand - lower) / (upper - lower) + 1); + (int64_t)((double)bucketCount * (operand - lower) / (upper - lower) + + 1); } if (bound1 > bound2) { diff --git a/velox/functions/prestosql/tests/utils/FunctionBaseTest.cpp b/velox/functions/prestosql/tests/utils/FunctionBaseTest.cpp index 2eab794bf449..51c98f98f194 100644 --- a/velox/functions/prestosql/tests/utils/FunctionBaseTest.cpp +++ b/velox/functions/prestosql/tests/utils/FunctionBaseTest.cpp @@ -125,16 +125,13 @@ void FunctionBaseTest::testEncodings( testDictionary(size, [&](auto row) { return size - 1 - row; }); // Repeat each row twice: 0, 0, 1, 1,... Add some nulls. - testDictionary( - size * 2, [](auto row) { return row / 2; }, nullEvery(3)); + testDictionary(size * 2, [](auto row) { return row / 2; }, nullEvery(3)); // Select even rows: 0, 2, 4,... Add some nulls. - testDictionary( - size / 2, [](auto row) { return row * 2; }, nullEvery(3)); + testDictionary(size / 2, [](auto row) { return row * 2; }, nullEvery(3)); // Go over all rows in reverse: N, N-1, N-2,...0. Add some nulls. - testDictionary( - size, [&](auto row) { return size - 1 - row; }, nullEvery(3)); + testDictionary(size, [&](auto row) { return size - 1 - row; }, nullEvery(3)); // Generate constant vectors and verify the results. for (auto i = 0; i < size; ++i) { diff --git a/velox/functions/sparksql/tests/ComparisonsTest.cpp b/velox/functions/sparksql/tests/ComparisonsTest.cpp index 4ffab43080c5..50f39df22b31 100644 --- a/velox/functions/sparksql/tests/ComparisonsTest.cpp +++ b/velox/functions/sparksql/tests/ComparisonsTest.cpp @@ -187,8 +187,8 @@ TEST_F(ComparisonsTest, testdictionary) { return BaseVector::wrapInConstant(base->size(), 0, base); }; // Lhs: 0, null, 2, null, 4. - auto lhs = makeFlatVector( - 5, [](auto row) { return row; }, nullEvery(2, 1)); + auto lhs = + makeFlatVector(5, [](auto row) { return row; }, nullEvery(2, 1)); auto rhs = makeFlatVector({1, 0, 3, 0, 5}); auto lhsVector = makeDictionary(lhs); auto rhsVector = makeDictionary(rhs); @@ -199,8 +199,7 @@ TEST_F(ComparisonsTest, testdictionary) { // Result : false, null, false, null, false. facebook::velox::test::assertEqualVectors( result, - makeFlatVector( - 5, [](auto row) { return false; }, nullEvery(2, 1))); + makeFlatVector(5, [](auto row) { return false; }, nullEvery(2, 1))); auto constVector = makeConstant(100, 5); auto testConstVector = makeRowVector({makeDictionary(lhs), makeConstantDic(constVector)}); @@ -211,8 +210,7 @@ TEST_F(ComparisonsTest, testdictionary) { fmt::format("{}(c0, c1)", "lessthanorequal"), testConstVector); facebook::velox::test::assertEqualVectors( constResult, - makeFlatVector( - 5, [](auto row) { return true; }, nullEvery(2, 1))); + makeFlatVector(5, [](auto row) { return true; }, nullEvery(2, 1))); // Lhs: const 100. // Rhs: 0, null, 2, null, 4. // Greaterthanorequal result : true, null, true, null, true. @@ -222,8 +220,7 @@ TEST_F(ComparisonsTest, testdictionary) { fmt::format("{}(c0, c1)", "greaterthanorequal"), testConstVector1); facebook::velox::test::assertEqualVectors( constResult1, - makeFlatVector( - 5, [](auto row) { return true; }, nullEvery(2, 1))); + makeFlatVector(5, [](auto row) { return true; }, nullEvery(2, 1))); } TEST_F(ComparisonsTest, testflat) { @@ -231,8 +228,8 @@ TEST_F(ComparisonsTest, testflat) { auto vector1 = makeFlatVector( 4, [](auto row) { return row + 1; }, nullEvery(2)); - auto expectedResult = makeFlatVector( - 4, [](auto row) { return true; }, nullEvery(2)); + auto expectedResult = + makeFlatVector(4, [](auto row) { return true; }, nullEvery(2)); auto actualResult = evaluate>( "lessthan(c0, c1)", makeRowVector({vector0, vector1})); facebook::velox::test::assertEqualVectors(expectedResult, actualResult); diff --git a/velox/tpch/gen/dbgen/bm_utils.cpp b/velox/tpch/gen/dbgen/bm_utils.cpp index 077942822330..3e1a49034f08 100644 --- a/velox/tpch/gen/dbgen/bm_utils.cpp +++ b/velox/tpch/gen/dbgen/bm_utils.cpp @@ -41,7 +41,7 @@ #include #include #ifndef _POSIX_SOURCE -//#include +// #include #endif /* POSIX_SOURCE */ #include #include @@ -51,8 +51,8 @@ #ifndef _POSIX_ #include // @manual #ifndef S_ISREG -#define S_ISREG(m) (((m)&_S_IFMT) == _S_IFREG) -#define S_ISFIFO(m) (((m)&_S_IFMT) == _S_IFIFO) +#define S_ISREG(m) (((m) & _S_IFMT) == _S_IFREG) +#define S_ISFIFO(m) (((m) & _S_IFMT) == _S_IFIFO) #endif #endif #ifndef stat diff --git a/velox/tpch/gen/dbgen/build.cpp b/velox/tpch/gen/dbgen/build.cpp index 59b321cff79b..8882b4e3adf4 100644 --- a/velox/tpch/gen/dbgen/build.cpp +++ b/velox/tpch/gen/dbgen/build.cpp @@ -25,7 +25,7 @@ #define LEAP_ADJ(yr, mnth) ((LEAP(yr) && (mnth) >= 2) ? 1 : 0) #define JDAY_BASE 8035 /* start from 1/1/70 a la unix */ #define JMNTH_BASE (-70 * 12) /* start from 1/1/70 a la unix */ -#define JDAY(date) ((date)-STARTDATE + JDAY_BASE + 1) +#define JDAY(date) ((date) - STARTDATE + JDAY_BASE + 1) #define PART_SUPP_BRIDGE(tgt, p, s) \ { \ DSS_HUGE tot_scnt = ctx->tdefs[SUPP].base * ctx->scale_factor; \ diff --git a/velox/tpch/gen/dbgen/include/dbgen/config.h b/velox/tpch/gen/dbgen/include/dbgen/config.h index d12d39147280..78b2c9031733 100644 --- a/velox/tpch/gen/dbgen/include/dbgen/config.h +++ b/velox/tpch/gen/dbgen/include/dbgen/config.h @@ -107,8 +107,8 @@ #endif /* LINUX */ #ifdef MAC -//#define _POSIX_C_SOURCE 200112L -//#define _POSIX_SOURCE +// #define _POSIX_C_SOURCE 200112L +// #define _POSIX_SOURCE #define STDLIB_HAS_GETOPT #define SUPPORT_64BITS #define DSS_HUGE long long diff --git a/velox/type/tests/FilterTest.cpp b/velox/type/tests/FilterTest.cpp index e7c10677fddc..0ff60695bfcb 100644 --- a/velox/type/tests/FilterTest.cpp +++ b/velox/type/tests/FilterTest.cpp @@ -1310,8 +1310,8 @@ void testMergeWithBytes(Filter* left, Filter* right) { merged->testBytes(test.data(), test.size()), left->testBytes(test.data(), test.size()) && right->testBytes(test.data(), test.size())) - << test << " " - << "left: " << left->toString() << ", right: " << right->toString() + << test << " " << "left: " << left->toString() + << ", right: " << right->toString() << ", merged: " << merged->toString(); } } diff --git a/velox/type/tests/TypeTest.cpp b/velox/type/tests/TypeTest.cpp index f377ba3e5a72..f2e91b842d38 100644 --- a/velox/type/tests/TypeTest.cpp +++ b/velox/type/tests/TypeTest.cpp @@ -627,8 +627,7 @@ TEST(TypeTest, equality) { // mix EXPECT_FALSE(MAP(REAL(), INTEGER()) - -> - operator==(*ROW({{"a", REAL()}, {"b", INTEGER()}}))); + ->operator==(*ROW({{"a", REAL()}, {"b", INTEGER()}}))); EXPECT_FALSE(ARRAY(REAL())->operator==(*ROW({{"a", REAL()}}))); } diff --git a/velox/vector/tests/DecodedVectorTest.cpp b/velox/vector/tests/DecodedVectorTest.cpp index 01cb6540aa34..c9c3f6be9f5b 100644 --- a/velox/vector/tests/DecodedVectorTest.cpp +++ b/velox/vector/tests/DecodedVectorTest.cpp @@ -1195,8 +1195,8 @@ TEST_F(DecodedVectorTest, flatNulls) { } // Flat vector with nulls. - auto flatWithNulls = makeFlatVector( - 100, [](auto row) { return row; }, nullEvery(7)); + auto flatWithNulls = + makeFlatVector(100, [](auto row) { return row; }, nullEvery(7)); auto check = [&](auto& d) { ASSERT_TRUE(d.nulls(nullptr) != nullptr); @@ -1223,8 +1223,8 @@ TEST_F(DecodedVectorTest, dictionaryOverFlatNulls) { DecodedVector d; auto flatNoNulls = makeFlatVector(100, [](auto row) { return row; }); - auto flatWithNulls = makeFlatVector( - 100, [](auto row) { return row; }, nullEvery(7)); + auto flatWithNulls = + makeFlatVector(100, [](auto row) { return row; }, nullEvery(7)); auto decodeAndCheckNulls = [&](auto& vector) { { diff --git a/velox/vector/tests/VectorSaverTest.cpp b/velox/vector/tests/VectorSaverTest.cpp index e2735201ce33..36e26e152eb7 100644 --- a/velox/vector/tests/VectorSaverTest.cpp +++ b/velox/vector/tests/VectorSaverTest.cpp @@ -176,8 +176,8 @@ class VectorSaverTest : public testing::Test, public VectorTestBase { testRoundTrip(makeFlatVector(10'000, [](auto row) { return row; })); // Long vector with nulls. - testRoundTrip(makeFlatVector( - 10'000, [](auto row) { return row; }, nullEvery(17))); + testRoundTrip( + makeFlatVector(10'000, [](auto row) { return row; }, nullEvery(17))); } // Verifies that the lazy vectors have the right internal state and loaded diff --git a/velox/vector/tests/VectorTest.cpp b/velox/vector/tests/VectorTest.cpp index c825cdfc3e9e..eb992afe7d3d 100644 --- a/velox/vector/tests/VectorTest.cpp +++ b/velox/vector/tests/VectorTest.cpp @@ -1402,8 +1402,8 @@ TEST_F(VectorTest, copyFromUnknown) { TEST_F(VectorTest, wrapInConstant) { // wrap flat vector const vector_size_t size = 1'000; - auto flatVector = makeFlatVector( - size, [](auto row) { return row; }, nullEvery(7)); + auto flatVector = + makeFlatVector(size, [](auto row) { return row; }, nullEvery(7)); auto constVector = std::dynamic_pointer_cast>( BaseVector::wrapInConstant(size, 5, flatVector)); @@ -1494,8 +1494,8 @@ TEST_F(VectorTest, wrapInConstant) { TEST_F(VectorTest, wrapInConstantWithCopy) { // Wrap flat vector. const vector_size_t size = 1'000; - auto flatVector = makeFlatVector( - size, [](auto row) { return row; }, nullEvery(7)); + auto flatVector = + makeFlatVector(size, [](auto row) { return row; }, nullEvery(7)); auto constVector = std::dynamic_pointer_cast>( BaseVector::wrapInConstant(size, 5, flatVector, true)); diff --git a/velox/vector/tests/VectorTestUtils.h b/velox/vector/tests/VectorTestUtils.h index 225f1ba22855..be04bb310106 100644 --- a/velox/vector/tests/VectorTestUtils.h +++ b/velox/vector/tests/VectorTestUtils.h @@ -212,8 +212,7 @@ void assertVector( if (isNull) { if (dbgPrintVec) { - LOG(INFO) << "[" << i << "]:" - << "NULL"; + LOG(INFO) << "[" << i << "]:" << "NULL"; } EXPECT_EQ(isNull, actualIsNull); } else { diff --git a/velox/vector/tests/VectorToStringTest.cpp b/velox/vector/tests/VectorToStringTest.cpp index 2910b46716ae..ef230eef7b11 100644 --- a/velox/vector/tests/VectorToStringTest.cpp +++ b/velox/vector/tests/VectorToStringTest.cpp @@ -33,8 +33,8 @@ TEST_F(VectorToStringTest, flatIntegers) { ASSERT_EQ(flat->toString(3, 8, ", ", false), "4, 5, 6, 7, 8"); // With nulls. - flat = makeFlatVector( - 100, [](auto row) { return row; }, nullEvery(3)); + flat = + makeFlatVector(100, [](auto row) { return row; }, nullEvery(3)); ASSERT_EQ(flat->toString(), "[FLAT INTEGER: 100 elements, 34 nulls]"); ASSERT_EQ(flat->toString(true), "[FLAT INTEGER: 100 elements, 34 nulls]"); ASSERT_EQ(flat->toString(1), "1");