fix: remove trailing / from nested paths #150
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR attempts to fix #134.
Currently, API documentation for nested routes is built by combining the path of the base route (with trailing slashes removed) with the path of the nested route.
If a path of a nested route is only "/", as seen in the todo list example, this leads to that path now containing a trailing slash:
Generates this path:
This PR fixes this issue by removing any trailing slahes after the nested path is built in the
nest
andnest_api_service
functions.One edge case needs to be handled. In a construct like the following:
the path of this route would be empty. A route of just
/
is therefore returned unmodified.I've also added a basic unit test.
This seems to be a simple fix, I hope I didn't miss any other cases here.