-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[regression] Polyglot breaks contract of ModelReader#read #321
Comments
This was referenced Aug 12, 2024
The build now suceeds, so this proves that null / empty map was possible and yields the same result in |
Here is the PR with just the version update now: |
Merged
cstamas
added a commit
that referenced
this issue
Sep 7, 2024
TeslaModelProcessor _must be Typed_ just like the DefaultModelProcessor in maven-core Fixes #321
I can confirm that this seem to fix the issue we are seeing: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This worked in
0.7.0
but fails in0.7.1
The javadoc of
ModelReader#read
clearly states that null is allowed as an optionbut calling it with with
null
when polyglot is enabled results inTrying to pass an empty map as a workaround fails like this:
I now created some PRs to see if one can narrow this down, this checks if passing an empty Map worked with the
0.7.0
version of polyglot previously:This removes the
The text was updated successfully, but these errors were encountered: