Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 - Multi-Select - tuiDropdownOpenChange emitting two events #9609

Open
blendirugova opened this issue Oct 25, 2024 · 1 comment
Open
Labels
contributions welcome Architecture is clear and community can help P3 This issue has low priority S3 This issue has low severity

Comments

@blendirugova
Copy link

blendirugova commented Oct 25, 2024

Reproduction url

https://stackblitz.com/edit/angular-u8tdmj?file=src%2Fapp%2Fapp.component.html

Description

When opening and closing the multi-select dropdown two events are being emitted from the tuiDropdownOpenChange output. Check stackblitz for example.

Taiga UI version

3.96

Browser Used

Chrome

OS Used

macOS

@waterplea
Copy link
Collaborator

We need to change the output here to pipe:
https://github.com/taiga-family/taiga-ui/blob/main/projects/core/directives/dropdown/dropdown-open-legacy.directive.ts#L14

private readonly stream$ = new BehaviorSubject(false);  

@Output()
public readonly tuiDropdownOpenChange = this.stream$.pipe(
  distinctUntilChanged(),
  skip(1),
);

@waterplea waterplea added contributions welcome Architecture is clear and community can help P3 This issue has low priority S3 This issue has low severity and removed state: need triage labels Nov 5, 2024
@splincode splincode removed the bug label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome Architecture is clear and community can help P3 This issue has low priority S3 This issue has low severity
Development

No branches or pull requests

3 participants