Replace DataType with const Type* throughout the codebase #7850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
Ris-Bali
changed the title
for more information, see https://pre-commit.ci
|
|
|
Hey @Ris-Bali, are you still working on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5167
Brief Summary
This PR aims to replace Type with const* type as types are not modified after creation.
🤖 Generated by Copilot at f905901
This pull request refactors the
Typesystem in thetaichi/irmodule to improve const correctness and avoid unnecessary copies. It changes theTypeFactoryclass and its methods to useconst Type *pointers, and addsconstqualifiers to various members and parameters of theTypeclass and its subclasses. It also updates some files intaichi/irto match the new type system.Walkthrough
🤖 Generated by Copilot at f905901
Typeobjects immutable and useconst Type *instead ofType *inTypeFactoryand related classes (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)