Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn instead of failing on HEIC conversion failure #19

Closed
tagatac opened this issue Jul 16, 2022 · 2 comments · Fixed by #21
Closed

Warn instead of failing on HEIC conversion failure #19

tagatac opened this issue Jul 16, 2022 · 2 comments · Fixed by #21
Assignees
@tagatac
Labels
bug Something isn't working

Comments

@tagatac
Copy link
Owner

tagatac commented Jul 16, 2022

My conversion stalled in the middle with this error:

decode HEIC image: error reading "ftyp" box: got box type "$\x14Ex" instead

Originally posted by @richardsprague in #16 (comment)
@tagatac tagatac added the bug Something isn't working label Jul 16, 2022
@tagatac
Copy link
Owner Author

tagatac commented Jul 16, 2022

This should be combined with a broader look at which errors should be hard failures and which should be warnings.

@tagatac tagatac self-assigned this Jul 16, 2022
@tagatac tagatac mentioned this issue Jul 17, 2022
Merged
@tagatac
Copy link
Owner Author

tagatac commented Jul 17, 2022

@richardsprague are you able to export to PDF using v2.0.4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tagatac tagatac

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warn instead of failing when HEIC file conversion fails tagatac/bagoup
1 participant
@tagatac