Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes in unescape routine #771

Merged
merged 10 commits into from
Jun 29, 2024
Merged

Fixes in unescape routine #771

merged 10 commits into from
Jun 29, 2024

Commits on Jun 27, 2024

  1. Rename EscapeError::UnrecognizedSymbol to `EscapeError::Unrecognize… 

    …dEntity` and tweak error message
    @Mingun
    Mingun committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    b9fcf6e View commit details
    Browse the repository at this point in the history

  2. Implement PartialEq for EscapeError and adopt tests to that.

    @Mingun
    Mingun committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    10bfa87 View commit details
    Browse the repository at this point in the history

  3. Move all escape tests into integration tests

    @Mingun
    Mingun committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    d6aedc0 View commit details
    Browse the repository at this point in the history

  4. Check for concrete errors in unescape tests

    @Mingun
    Mingun committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    cf10782 View commit details
    Browse the repository at this point in the history

  5. Do not restrict maximal length of the character reference 

    XML allows any number of leading zeroes. That is not explicitly mentioned
in the specification, but enforced by the conformance test suite
(https://www.w3.org/XML/Test/)
    @Mingun
    Mingun committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    55a537a View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Use standard methods to parse character reference to a number

    @Mingun
    Mingun committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    04bddd6 View commit details
    Browse the repository at this point in the history

  2. Do not allow (positive) sign in character references 

    Negative sing will return ParseIntError(InvalidDigit) because we parse into unsigned number,
but `+` sign is allowed by the parse method. To return the same error for both `+` and `-`
we check for sign itself before parse
    @Mingun
    Mingun committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    42d7123 View commit details
    Browse the repository at this point in the history

  3. Add helper to decoder Cow data, which retains original lifetime

    @Mingun
    Mingun committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    80bf12d View commit details
    Browse the repository at this point in the history

  4. Reuse existing method with does the same thing when encoding featur… 

    …e is disabled
    @Mingun
    Mingun committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    aa1d391 View commit details
    Browse the repository at this point in the history

  5. Fix Attribute::unescape_value does not unescape predefined entities s… 

    …ince tafia#739
    @Mingun
    Mingun committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0315ed0 View commit details
    Browse the repository at this point in the history