Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add oneof trailing semi support #264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qazxcdswe123
Copy link

@qazxcdswe123 qazxcdswe123 commented Oct 16, 2024

fix: #261

test copied from: https://github.com/onnx/onnx/blob/1e3be88265ec2aa84a5177f8282d5d64bb6bb4a0/onnx/onnx.proto#L694

The trailing semi for nested message is optional, others like message or enum corretly handle it but oneof does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pb-rs fails when processing a oneof with a semicolon
1 participant