Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing the underlying TLS stream #13

Open
howardmoore opened this issue Apr 12, 2020 · 2 comments
Open

Accessing the underlying TLS stream #13

howardmoore opened this issue Apr 12, 2020 · 2 comments

Comments

@howardmoore
Copy link

Would you consider making your ProxyStream implementation public and also switching form using tokio_tls to tokio_native_tls?

The reason I'm asking is because I'd like to be able to access the underlying TLS stream of a proxied connection, to do some further validation of the server certificate. This is almost possible using the Upgrade mechanism in hyper but to downcast the hyper::upgrade::Upgraded back to its underlying stream requires your ProxyStream struct to be made public and requires it to use a tokio_native_tls::TlsStream not a tokio_tls::TlsStream as the latter doesn't allow access to the underlying native_tls stream (and also looks to be deprecated in favour of the former).

@lynnux
Copy link

lynnux commented Apr 26, 2020

yes, same as tunnel, they both helpful, please consider make them pub

@tafia
Copy link
Owner

tafia commented May 16, 2020

I would definitely consider it.
I am on a very low bandwidth since some time now but I'd be happy to share ownership with someone if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants