Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilizing gradle-env{.json,.nix} format/interface #30

Open
ghost opened this issue Dec 6, 2020 · 2 comments
Open

stabilizing gradle-env{.json,.nix} format/interface #30

ghost opened this issue Dec 6, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 6, 2020

Since we had the discussion on breaking changes in NixOS/nixpkgs#77422 I've kind of been waiting for a 1.0.0 release in the assumption that there might be more breaking changes until then. So I would like to track the status of this stabilization here. What is still to be done, or can we use gradle2nix in nixpkgs as-is?

@tadfisher
Copy link
Owner

Packaging gradle2nix should be fine, so I would start with that.

I sort of disagree with integrating the buildGradle function in nixpkgs. We don't do that for node2nix, for example, which gives node2nix the freedom to change their lockfile format. So I'd prefer we didn't do that, and just package both gradle-env.nix and gradle-env.json with each derivation that needs them.

@tadfisher
Copy link
Owner

One incompatible change I want to make is to switch to SRI hashes, so I will likely rename the sha256 field for dependency objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant