Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed panic on fetch returning empty response #124

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

syumai
Copy link
Owner

@syumai syumai commented Aug 11, 2024

What

  • Stopped using ToStreamResponse in fetch func and replaced it to ToResponse.

Motivation

  • Current implementation of fetch panics when fetch result body is empty (No Content).
  • The piping logic to TransformStream is causing this issue.
    • Stream responses without TransformStream piping are already working since the following commit: bf3ab8e.
    • Therefore, I've stopped using TransformStream piping.

@syumai syumai self-assigned this Aug 11, 2024
@syumai syumai merged commit ad33cfb into main Aug 11, 2024
2 checks passed
@syumai syumai deleted the fix-fetch-stream-empty-response branch August 11, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant