Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add template of Cron Triggers worker #49

Closed
syumai opened this issue Apr 30, 2023 · 7 comments
Closed

Add template of Cron Triggers worker #49

syumai opened this issue Apr 30, 2023 · 7 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@syumai
Copy link
Owner

syumai commented Apr 30, 2023

  • For convinience, add Cron Triggers worker template into _templates/cloudflare directory.
@syumai syumai added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 30, 2023
@vhespanha
Copy link

Can i take this one?

@syumai
Copy link
Owner Author

syumai commented Jun 25, 2024

@vhespanha Thank you!

@vhespanha vhespanha mentioned this issue Jun 26, 2024
Merged
@vhespanha
Copy link

Hey!

Gave it a try, mind taking a look? #118 (Opened it as draft because this is my first open-source PR)

Thank you.

@syumai
Copy link
Owner Author

syumai commented Jun 26, 2024

@vhespanha I'll check this later, thanks!

@syumai
Copy link
Owner Author

syumai commented Jun 26, 2024

@vhespanha I checked #118 and it seemed to be mostly fine.
Just a small fix, please write TinyGo as tinygo instead of tiny-go. (In the official repository it is written as tinygo.)
Once you fix the PR, please open it!
I will check it again after that. Thank you!!

@vhespanha
Copy link

vhespanha commented Jun 26, 2024 •
edited
Loading

Hey, sorry for the oversight. Fixed it and pushed again.

2a97a83

@syumai
Copy link
Owner Author

syumai commented Jun 26, 2024

@vhespanha Thank you! I've merged the PR! 🚀

@syumai syumai closed this as completed Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@syumai @vhespanha