fix: pdf's background color is now loaded by _pdfViewerThemeData #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@f-dedecube, this makes the page color the same as the background color of the PDF viewer, leading to a poor user experience when scrolling through the pages using the scroll bar. By setting the background color to Colors.white, users can more clearly distinguish where each page begins and ends during scrolling. Please find the comparison video recordings below, Existing (Colors.white): Screen.Recording.2024-08-19.105847.mp4PR changes (_pdfViewerThemeData.backgroundColor): Screen.Recording.2024-08-19.105817.mp4 |
Deepak1799
added
the
waiting for customer response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, the background is no longer white by default but is now loaded from the theme data.