Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layout handling #4

Open
2 of 4 tasks
zyro23 opened this issue Apr 23, 2019 · 0 comments · May be fixed by #7
Open
2 of 4 tasks

layout handling #4

zyro23 opened this issue Apr 23, 2019 · 0 comments · May be fixed by #7

Comments

@zyro23
Copy link

zyro23 commented Apr 23, 2019

Task List

  • Steps to reproduce provided
  • Stacktrace (if present) provided
  • Example that reproduces the problem uploaded to Github
  • Full description of the issue provided (see below)

Steps to Reproduce

  1. set quartz.monitor.layout: main
  2. go to /quartz
  3. check result

Expected Behaviour

the layout should default to main (at least according to the readme). it does not (needed setting the layout to main explicitly).

loading the list view, the javascript (i.e. jquery) pulled in via applications' main layout should load before the quartz-monitor javascript kicks in.

Actual Behaviour

the response for the list view looks somewhat like this:

<html>
<head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
    <title>Quartz Jobs</title>
    <script type="text/javascript" src="/assets/schwartz-monitor-main.js?compile=false" ></script>
    <script type="text/javascript" src="/assets/schwartz-monitor.js?compile=false" ></script>
    <link rel="stylesheet" href="/assets/schwartz-monitor-main.css?compile=false" />
    <link rel="stylesheet" href="/assets/schwartz-monitor.css?compile=false" />
    <script type="text/javascript" src="/assets/jquery.countdown.js?compile=false" ></script>
    <script type="text/javascript" src="/assets/jquery.color.js?compile=false" ></script>
    <link rel="stylesheet" href="/assets/jquery.countdown.css?compile=false" />
    <script type="text/javascript" src="/assets/jquery.clock.js?compile=false" ></script>
    <link rel="stylesheet" href="/assets/jquery.clock.css?compile=false" />
</head>
<body>

<!DOCTYPE html>
<html>
    <head>
        <%-- application head (no quartz monitor related assets) here --%>
    </head>
    <body>
        <%-- application body with quartz list table here --%>
    </body>
</html>

</body>
</html>

that is not just invalid markup, it also loads the quartz-monitor javascripts before the applications' , so jQuery is not defined and application asset loading breaks too (e.g. main navbar not working properly).

i can only guess that this here is too late (should maybe moved to to the top of the head)? https://github.com/robertoschwald/grails-schwartz-monitor/blob/2.0.2/plugin/grails-app/views/quartz/list.gsp#L20

Environment Information

  • Operating System: win x64
  • GORM Version: 6.1.11
  • Grails Version (if using Grails): 3.3.9
  • JDK Version: oracle 8u131

Example Application

  • needed? can reference one..
robertoschwald added a commit that referenced this issue Apr 26, 2021
@robertoschwald
#4 fix views
e14d766
@robertoschwald robertoschwald linked a pull request May 12, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

maven central and view fix symentis/grails-schwartz-monitor
1 participant
@zyro23