Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS Review: Paper questions #11

Open
6 tasks done
erexer opened this issue Sep 4, 2024 · 5 comments
Open
6 tasks done

JOSS Review: Paper questions #11

erexer opened this issue Sep 4, 2024 · 5 comments

Comments

@erexer
Copy link

erexer commented Sep 4, 2024

This is for the JOSS Review.

  • Can you provide a source for the data used in Figure 2.
  • You mention that there are other programs used for seismic processing, can you give the names of those and cite them.

typos/grammar

  • "Figure Figure 2 shows the layout..." says "Figure" twice
  • "Other commercial software for monitoring picoseismicity for structural health monitoring applications, e.g. in mines exists, but are only trigger-based" the commas in this sentence are incorrect, should be "Other commercial software for monitoring picoseismicity for structural health monitoring applications, e.g., in mines, exists but are only trigger-based".
  • "For large-scale experiments in underground laboratories (e.g., hydraulic stimulation, earthquake nucleation, nuclear waste disposal) continuous recordings of the seismicity data streams in MHz range are needed to study the rock response in great detail" should have a comma "For large-scale experiments in underground laboratories (e.g., hydraulic stimulation, earthquake nucleation, nuclear waste disposal), continuous recordings of the seismicity data streams in MHz range are needed to study the rock response in great detail"
  • "Since the software is python based, users can easily add their own processing routines." Python should be capitalized.

I'd recommend running the paper through a grammar checker.

@mrosskopf
Copy link
Collaborator

Hi,
thank you for your suggestions. I adjusted the text and also ran it through a grammar checker again.
I changed the event that was displayed in Figure 2. The one displayed now is just a few hours later, but the waveforms and channel information are already on zenodo. To open it in GUI, you can use the yaml file (just change the paths) and the sqlite file I now provided in the paper folder of the repository, plus the given waveform and channel information from zenodo.
Are there any other suggestions to this topic? :)

@erexer
Copy link
Author

erexer commented Sep 9, 2024

Thanks! Could you add GMuG as a citation and make it clear in Figure 2 that the data comes from Rosskopf et al. 2024 (put it in the caption).

@mrosskopf
Copy link
Collaborator

Hi, I slightly changed the text to not include a citation in the summary section but I added the website of GMuG and of another software in the section "Statement of need" after slightly changing the text. The software itself do not have a direct citation, but I hope it is fine with the websites.
I also added the data citation in the caption.

@erexer
Copy link
Author

erexer commented Sep 16, 2024

You need a comma at the end of this line so that the paper will render correctly :)

@mrosskopf
Copy link
Collaborator

Ah yes, of course! Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants