use of "comment" for event classification

[kaestli]

Currently, event classificatiions are stored as quakeML "comment" objects, with "id" attribute set to a random UUID, and "text" to (e.g.): "Classification: passive".
This is a misinterpretation of the quakeML event object.
comment ID is intended to hold an identifyer of the comment type; e.g. "smi:ch.ethz.bedrettolab/DUGseis-eventclass", and text the actual value of the comment, e.g. "active". This will allow a later user of the data to find/extract all comments of the same type.

Having said that, for the classification of interest, quakeML also offers an explicit data field:
event.eventtype, being one of:
not existing
• not reported
• earthquake
• anthropogenic event
• collapse
• cavity collapse
• mine collapse
• building collapse
• explosion
• accidental explosion
• chemical explosion
• controlled explosion
• experimental explosion
• industrial explosion
• mining explosion
• quarry blast
• road cut
• blasting levee
• nuclear explosion
• induced or triggered event
• rock burst
• reservoir loading
• fluid injection
• fluid extraction
• crash
• plane crash
• train crash
• boat crash
• other event
• atmospheric event
• sonic boom
• sonic blast
• acoustic noise
• thunder
• avalanche
• snow avalanche
• debris avalanche
• hydroacoustic event
• ice quake
if all classes can be satisfied from this list, it would be more straight-forward to use event.eventtype for classification than a custom comment.

[krischer]

So the comment identifier does not have to be unique?

This is not hard-coded in the core of DUGSeis and could be changed for each processing script:

DUGseis/scripts/run_processing.py

Lines 132 to 136 in 0cefbff

	event.comments = [
	obspy.core.event.Comment(
	text=f"Classification: {event_candidate['classification']}"
	)
	]

One could either add a resource identifier with the proper string or an actual event type object.

[kaestli]

no. the ID identifies the "type-of-comment".
Thx. I will not change it now (people are in the last preparations of starting to operate tomorrow and would go crazy), but fix after the first stimulation