-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if CorrectAnswer
passes the tests in AnswerTests
#14
Comments
Sounds very interesting! Send us a PR and I'll take a look. I always appreciate your work Wush. |
Dear @seankross ChihChengLiang will give you a PR because this feature is proposed by him and the credit should be his. |
I'm eagerly awaiting it! |
I aware that you implementing I am also improving the testing script for my own swirl course. Is it possible for us to work together? I think the current process makes it hard to directly merge the changes into the branch 3.1 and makes it hard for me to understand your latest thinking about the testing script. |
Hi @wush978, I absolutely want to continue working together! What repository and branch have you been working on recently? I'll take a look at that and then I'll explain how I see your ideas fitting into what I've done. |
Dear @seankross, In fact my latest test scripts were written in my own swirl course project. I am glad to contribute them into swirlify. Both I and @ChihChengLiang are familiar with github, so you can give us a branch and we could keep sending pull request for you. According to previous experience, I think manually merge these codes will make it harder to work together because we might miss your opinions of our PR. For example, I was confused about the latest change of To make |
I had a similar thing in mind (improving the scope of testing while creating course content and potentially extending this to CI/automated testing). This would be a great addition to swirlify! |
Dear maintainers,
Thanks for your work of swirlify. I am using
swirlify
to develop our swirl course and this is great. However, I guess theswirlify::testit
does not automatically check ifCorrectAnswer
passes the tests inAnswerTests
.ChihChengLiang and I develop a test script which scans the
lesson.yaml
and tests if allCorrectAnswer
passes theAnswerTests
. Based on this test, I build up aCI system (Based on Appveyor and Travis-CI) to check the syntax of the
lesson.yaml
and validate if the answers are correct or not. I think this feature is very useful to develop a swirl course.Could we send a PR to let swirlify has a function to automatically test all answers?
Best,
Wush
The text was updated successfully, but these errors were encountered: