Fix rust and js tests [AP-949] #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodfell
requested review from
notoriaga,
pcrumley,
jungleraptor and
a team
as code owners
RReichert
approved these changes
Nov 22, 2023
|
[libsbp-c] Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/devinfra
Not every CI stage ran on #1382 so when it merged to master a few things broke. These were the JS test stage and one of the rust linting stages. The fixes are minor, correcting a badly written test spec with a duplicate YAML key, creating exceptions for several test cases in the JS tests, and omitting generation of rust tests files which don't contain any cases
API compatibility
Does this change introduce a API compatibility risk?
No
API compatibility plan
If the above is "Yes", please detail the compatibility (or migration) plan:
N/A
JIRA Reference
https://swift-nav.atlassian.net/browse/BOARD-XXXX