Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

structure recognition enhancements #1618

Merged
merged 6 commits into from
Nov 14, 2023
Merged

structure recognition enhancements #1618

merged 6 commits into from
Nov 14, 2023

Conversation

kostmo
Copy link
Member

@kostmo kostmo commented Nov 11, 2023 •
edited
Loading

  • Highlight occurrences of structures in markdown in red
  • Add a new blueprint entity to provide floorplan and structure commands
  • new floorplan command to get the dimensions of a structure
  • structure location is southwest instead of northwest corner
  • handle structures with "holes" for statically-recognized structures and when modifying interior cells post-recognition

Each of these is its own commit for reviewability's sake.

@kostmo kostmo added the L-Commands Built-in commands (e.g. move, try, if, ...) in the Swarm language. label Nov 11, 2023
@kostmo kostmo force-pushed the feature/structure-enhancements branch from d7616d0 to 099c610 Compare November 11, 2023 22:12
@kostmo kostmo marked this pull request as ready for review November 11, 2023 22:18
@kostmo kostmo requested a review from byorgey November 11, 2023 22:18
@kostmo kostmo force-pushed the feature/structure-enhancements branch 2 times, most recently from 8d59f6f to e493875 Compare November 13, 2023 02:05
@kostmo kostmo force-pushed the feature/structure-enhancements branch from e493875 to 7d3622b Compare November 13, 2023 04:52
byorgey
byorgey approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@byorgey byorgey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me!

@kostmo kostmo added the merge me Trigger the merge process of the Pull request. label Nov 14, 2023
@mergify mergify bot merged commit bd2de6c into main Nov 14, 2023
11 checks passed
@mergify mergify bot deleted the feature/structure-enhancements branch November 14, 2023 18:08
@kostmo kostmo mentioned this pull request Nov 21, 2023
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byorgey byorgey byorgey approved these changes

Assignees
No one assigned
Labels
L-Commands Built-in commands (e.g. move, try, if, ...) in the Swarm language. merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostmo @byorgey