Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly initialized game tries to "catch up" after sitting in the menu for a while #853

Closed
byorgey opened this issue Nov 12, 2022 · 3 comments · Fixed by #855
Closed

Newly initialized game tries to "catch up" after sitting in the menu for a while #853

byorgey opened this issue Nov 12, 2022 · 3 comments · Fixed by #855
Labels
Bug The observed behaviour is incorrect or unexpected. C-Low Hanging Fruit Ideal issue for new contributors. S-Moderate The fix or feature would substantially improve user experience.

Comments

@byorgey
Copy link
Member

byorgey commented Nov 12, 2022

Describe the bug
After spending a while letting the game sit in the menu, when starting a new scenario the game runs really fast for a little bit, as if it thinks it should have been running while the menu was active and it is now trying to "catch up".

To Reproduce
I first noticed this when testing out #835 (it was very noticeable since the sheep ran around really fast and quickly drowned themselves) but it can be seen in any scenario where the base has a clock installed.

  • Start the app
  • Let it sit in the menu for a while (e.g. a few minutes)
  • Now start the Classic game and look at the clock in the upper right. It will run fast for a little while and then at some point start running normally.

Expected behavior
The game should run at a normal speed regardless of how long you have spent in the menu.

@byorgey byorgey added Bug The observed behaviour is incorrect or unexpected. C-Low Hanging Fruit Ideal issue for new contributors. S-Moderate The fix or feature would substantially improve user experience. labels Nov 12, 2022
@xsebek
Copy link
Member

xsebek commented Nov 12, 2022

This sounds like a regression. I vaguely remember that the controller used to set some variables to avoid this.

@byorgey
Copy link
Member Author

byorgey commented Nov 12, 2022

I don't know if it's a regression or not. This has definitely been tricky to get right with respect to pausing, dialogs, etc. but I don't specifically remember whether we have dealt with it right at the start of the scenario before. We could in theory do a git bisect to figure out if there was a specific point where this was introduced, but that sounds very tedious due to the need to wait in the menu for a few minutes to test it.

@byorgey
Copy link
Member Author

byorgey commented Nov 12, 2022

I think it's very easy to fix. Patch incoming once I test it to be sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug The observed behaviour is incorrect or unexpected. C-Low Hanging Fruit Ideal issue for new contributors. S-Moderate The fix or feature would substantially improve user experience.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants