Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or deprecate stack build #1624

Closed
kostmo opened this issue Nov 14, 2023 · 3 comments · Fixed by #1627
Closed

Fix or deprecate stack build #1624

kostmo opened this issue Nov 14, 2023 · 3 comments · Fixed by #1627
Labels
Bug The observed behaviour is incorrect or unexpected. Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code.

Comments

@kostmo
Copy link
Member

kostmo commented Nov 14, 2023

Since #1617, cabal build works but stack build no longer does.

Do we believe that cabal has parity with stack for the purposes of our project? Then we should scrub/replace references to stack in our scripts and documentation.
@kostmo kostmo added Bug The observed behaviour is incorrect or unexpected. Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code. labels Nov 14, 2023
@kostmo kostmo mentioned this issue Nov 15, 2023
Closed
@byorgey
Copy link
Member

byorgey commented Nov 15, 2023

I don't think we should be so quick to get rid of stack. I use it for building swarm, and it's quite useful because anyone wanting to build swarm can be sure they will get a reproducible build, without worrying about whether they have the right version of GHC installed.

@byorgey
Copy link
Member

byorgey commented Nov 15, 2023

I didn't realize #1617 broke the stack build, but I will happily fix it.

byorgey added a commit that referenced this issue Nov 15, 2023
@byorgey
fix the stack build
5dee9b4 
Closes #1624.

Note, however, that currently (until #1623) this will not work on
Windows, since I explicitly added `vty-unix` as an `extra-dep` in the
`stack.yaml` file.  However, I expect we will get #1623 soon and then
we can remove it.
@byorgey byorgey mentioned this issue Nov 15, 2023
Merged
@mergify mergify bot closed this as completed in #1627 Nov 15, 2023
mergify bot pushed a commit that referenced this issue Nov 15, 2023
@byorgey
Fix the stack build (#1627)
8f52e53 
Closes #1624.

Note, however, that currently (until #1623) this will not work on Windows, since I explicitly added `vty-unix` as an `extra-dep` in the `stack.yaml` file.  However, I expect we will get #1623 soon and then we can remove it.
@kostmo
Copy link
Member Author

kostmo commented May 3, 2024

See #1798 (comment) for a demonstration of a stack bug regarding rebuilding a target that does not occur with cabal:

Try the following:

  1. Add a newline to the end of src/swarm-tournament/Swarm/Web/Tournament/Validate.hs
  2. Run stack build swarm:exe:swarm
  3. Observe that it recompiles swarm-tournament, despite that library not being a dependency of the swarm executable.

Now do the same cycle, but with cabal build swarm:exe:swarm instead, and observe Up to date is printed.

@byorgey byorgey mentioned this issue May 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug The observed behaviour is incorrect or unexpected. Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the stack build swarm-game/swarm
2 participants
@kostmo @byorgey