Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using the standard library "embed" #5

Open
zxysilent opened this issue Feb 23, 2021 · 7 comments
Open

Consider using the standard library "embed" #5

zxysilent opened this issue Feb 23, 2021 · 7 comments

Comments

@zxysilent
Copy link

zxysilent commented Feb 23, 2021

Consider using the standard library embed

It uses raw data and can reduce the size of the executable program compared with the current way

@mirecl
Copy link

mirecl commented Feb 24, 2021

I agree!!!
Good idea

@ubogdan
Copy link
Contributor

ubogdan commented Feb 27, 2021

Have you taken into consideration this will introduce beaking dependency for everyone using the go version before go1.16?
I don't see if this is going to be approved before go.17 is release.

@tylfin
Copy link

tylfin commented Jul 13, 2021

FYI, it looks like this work never go merged in. For those interested, I did write a drop-in replacement w/ go:embed and fs.FS, but it is incompatible with earlier versions of Go.

https://github.com/tylfin/gin-swagger-files

@Jictyvoo
Copy link

Jictyvoo commented Feb 3, 2023

Have you taken into consideration this will introduce beaking dependency for everyone using the go version before go1.16? I don't see if this is going to be approved before go.17 is release.

Currently it's possible to lock dependency version using go modules, for those that wants compatibility before go1.16, they can use the library with previous tags and versions

@Jictyvoo
Copy link

Jictyvoo commented Feb 3, 2023

It has any plans to merge this feature soon?

@Jictyvoo
Copy link

As #16 was merged, should this be closed?

@ubogdan
Copy link
Contributor

ubogdan commented Mar 28, 2023

I belive yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants