Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and tests #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update deps and tests #10

wants to merge 3 commits into from

Conversation

rhaist
Copy link

@rhaist rhaist commented Dec 15, 2022

Describe the PR
Update dependencies and adapt test

@rhaist
Copy link
Author

rhaist commented Dec 16, 2022

So it seems like github.com/mattn/go-runewidth depends on github.com/rivo/uniseg which requires Go 1.18.
I guess you don't want to require that as a minimum version for fiber-swagger ?

Based on https://endoflife.date/go I would recommend to upgrade the supported versions to 1.18 and 1.19.

@codecov
Copy link

codecov bot commented Jan 1, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (913fa3f) compared to base (bba772b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           59        59           
=========================================
  Hits            59        59           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ubogdan
Copy link
Contributor

ubogdan commented Jan 1, 2023

@rhaist This package returns a fiber.Handler so you can use it with your project.
Your PR simply drops support for anyone using an older version than go 1.18 which will introduce breaking changes.

For example, I use go 1.17 to build my projects for prod env.

By example we can drop version 1.15 to get in sync with swaggo/swag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants