Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for stripping optional peer dependencies #316

Open
rtkt opened this issue Aug 7, 2023 · 1 comment
Open

Add support for stripping optional peer dependencies #316

rtkt opened this issue Aug 7, 2023 · 1 comment

Comments

@rtkt
Copy link

rtkt commented Aug 7, 2023

Hi.
Peer dependencies can be marked as optional in NPM's package.json since v7 (proof) but looks like node2nix doesn't support stripping them.

Maybe I'll patch node2nix myself and open a pull request by the end of this week but I don't guarantee it.

@lilyinstarlight
Copy link
Contributor

Yeah I neglected to implement that when updating node2nix last for npm v7. Node2nix is fairly unmaintained these days, but if you need it, feel free to open a PR to this repo and then open a PR to nixpkgs to pull in the patch (and ping me to review on nixpkgs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants