Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blst_fp12 deserialization blst_fp12_from_bendian #167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

emlowe
Copy link

@emlowe emlowe commented Jun 7, 2023

blst_fp12 has a serialization function blst_bendian_from_fp12 - but was missing the corresponding deserialization function.

This PR adds blst_fp12_from_bendian for this purpose.

@emlowe emlowe changed the title Add blst_fp deserialization blst_fp12_from_bendian Add blst_fp12 deserialization blst_fp12_from_bendian Jun 7, 2023
@dot-asm
Copy link
Collaborator

dot-asm commented Jun 7, 2023

Come on! It's not like we don't know it's missing :-) :-) :-) But on a serious note, there is a reason for why deserialization is not implemented. Because there is no specification and we don't want to give an impression that there is. Well, maybe there is now, maybe even a draft, in which case it would be more appropriate to simply provide a reference. Serialization was added to aid the cross-checking with other libraries, but not for communications, which would require a specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants