-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support LiteStar #310
Comments
hey @Goldziher we are open to a PR. You would need to add Litestar as a framework just like how we have added flask (and others) as a framework: https://github.com/supertokens/supertokens-python/tree/master/supertokens_python/framework/flask
|
PR has been added @rishabhpoddar. I cannot make the tests pass locally - due to some issues with the testing setup (see my comment in the PR description). Frankly this testing setup is a bit too complex for my brain. I cannot debug this because the error seems to be in the root repo(?). The code I added is clean and it should be pretty close to so done. It would be great if you guys take this from this point onwards since you understand what is happening here and I don't. As an aside - I would suggest you guys switch your setup for tooling to using You can see a good example of this in the litestar repository, and im sure there are plenty of people who would love to contribute this for you guys (I know a few on our discord server). Feel free to join our server if you want assistance with this stuff or anything else. I'll be around to assist in what I can - I hope this PR moves forward. |
Nice job! I hope this PR goes through as i would like to use Supertokens and litestar in some of my projects! |
@Spectryx we will be reviewing the PR shortly, but until then, you could use the forked version of the SDK to test it out and see if you run into any issues (which will also help us with testing / reviewing). Thanks |
@rishabhpoddar Hi! Sure, i'll try to get it up and running with litestar later today and see how it goes! |
I cant get it to work, see this comment #311 (comment) |
I guess the attempt to include Litestar has been aborted? :( |
im out of the equation in litestar - you guys should reach out to the maintainers on discord to get support for this. |
We are still happy to accept the PR for Litestar if someone can work on it. |
We can update this once we are at the phase of CICD testing. You can test it locally with 3.8 python though |
Any update on this? I would really like to have Litestar support |
hey @pltoledo we are happy to accept a PR from the community for this. |
Hi there,
I'm one of the maintainers of Litestar. We received a request to add support for supertokens -> litestar-org/litestar#1497. I'm willing to put up a PR for this in this repository, is this something you would be interested in?
The text was updated successfully, but these errors were encountered: