Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LiteStar #310

Open
Goldziher opened this issue Apr 15, 2023 · 13 comments
Open

Support LiteStar #310

Goldziher opened this issue Apr 15, 2023 · 13 comments

Comments

@Goldziher
Copy link

Hi there,

I'm one of the maintainers of Litestar. We received a request to add support for supertokens -> litestar-org/litestar#1497. I'm willing to put up a PR for this in this repository, is this something you would be interested in?

@rishabhpoddar
Copy link
Member

hey @Goldziher we are open to a PR. You would need to add Litestar as a framework just like how we have added flask (and others) as a framework: https://github.com/supertokens/supertokens-python/tree/master/supertokens_python/framework/flask

@Goldziher
Copy link
Author

Goldziher commented Apr 15, 2023

PR has been added @rishabhpoddar. I cannot make the tests pass locally - due to some issues with the testing setup (see my comment in the PR description).

Frankly this testing setup is a bit too complex for my brain. I cannot debug this because the error seems to be in the root repo(?).

The code I added is clean and it should be pretty close to so done.

It would be great if you guys take this from this point onwards since you understand what is happening here and I don't.

As an aside - I would suggest you guys switch your setup for tooling to using pre-commit, mypy and ruff + a package manager that uses pyproject.toml such as poetry.

You can see a good example of this in the litestar repository, and im sure there are plenty of people who would love to contribute this for you guys (I know a few on our discord server). Feel free to join our server if you want assistance with this stuff or anything else.

I'll be around to assist in what I can - I hope this PR moves forward.

@Spectryx
Copy link

Nice job! I hope this PR goes through as i would like to use Supertokens and litestar in some of my projects!

@rishabhpoddar
Copy link
Member

@Spectryx we will be reviewing the PR shortly, but until then, you could use the forked version of the SDK to test it out and see if you run into any issues (which will also help us with testing / reviewing). Thanks

@Spectryx
Copy link

@rishabhpoddar Hi! Sure, i'll try to get it up and running with litestar later today and see how it goes!

@Spectryx
Copy link

I cant get it to work, see this comment #311 (comment)

@ctrl-Felix
Copy link

I guess the attempt to include Litestar has been aborted? :(

@Goldziher
Copy link
Author

im out of the equation in litestar - you guys should reach out to the maintainers on discord to get support for this.

@rishabhpoddar
Copy link
Member

We are still happy to accept the PR for Litestar if someone can work on it.

@bpereto bpereto mentioned this issue Apr 8, 2024
12 tasks
@bpereto
Copy link

bpereto commented Apr 8, 2024

I took the work from #311
and put it into a new one: #483

I didn't get the test to working, as litestar is expecting at least python 3.8 and the test environment seems to use 3.7.
any chance to update the test container?

@rishabhpoddar
Copy link
Member

any chance to update the test container?

We can update this once we are at the phase of CICD testing. You can test it locally with 3.8 python though

@pltoledo
Copy link

pltoledo commented Oct 6, 2024

Any update on this? I would really like to have Litestar support

@rishabhpoddar
Copy link
Member

hey @pltoledo we are happy to accept a PR from the community for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants