WIP: Add SSO via OIDC #1732
Draft
WIP: Add SSO via OIDC #1732
+1,275
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! Ideally we'd want this to be built by the team, but if you want to continue developing it we can have a sync some time? |
|
@hf Feel free to take of the code what you want/need depending on your level of NIH. There is no real novel code to begin with as I made an effort to reuse as much of the existing code paths as possible. I'm running my modified version on-top of a hosted supabase instance and that's all I needed for now. I did it mostly to re-familiarize myself with all the OIDC flows, state keeping, etc... For a lot of things I'm working on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
SSO via OIDC in additional to SAML
What is the current behavior?
SSO only with SAML
What is the new behavior?
SSO with SAML or OIDC possible
Additional context
This is a WIP! Not all necessary functionality is in there.
The GenericProvider was taken from @carlobeltrame PR #1372