FIX Password Reset Flow in SupaEmailAuth #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henry2man
changed the title
|
Added |
|
Yeah, second attempt! I was using an older flutter version that didn't trigger the new warnings. Now with % fvm flutter --version
Flutter 3.19.6 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 54e66469a9 (2 days ago) • 2024-04-17 13:08:03 -0700
Engine • revision c4cd48e186
Tools • Dart 3.3.4 • DevTools 2.31.1
% fvm flutter analyze --fatal-warnings --fatal-infos lib
Analyzing lib...
No issues found! (ran in 0.7s)@dshukertjr Why don't you use |
|
Can anyone take a look here? Thanks ❤️ |
dshukertjr
approved these changes
May 13, 2024
|
@dshukertjr You're welcome. I still miss some features here (add more possibilities to SignUp flow, more UI tweaks, #32...) so probably I will make more PR in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
FIXES #88
What is the current behavior?
Password reset flow is incomplete in
SupaEmailAuthWhat is the new behavior?
Successful password reset flow
Additional context
N/A