Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add footer or cleaner ending (at least crop negative space) #4

Open
SLarrick opened this issue Oct 27, 2016 · 2 comments
Open

Add footer or cleaner ending (at least crop negative space) #4

SLarrick opened this issue Oct 27, 2016 · 2 comments

Comments

@SLarrick
Copy link
Contributor

At the very least, scroll should stop closer to the bottom of the [WWC | Sunlight] logo (there is a lot of awk negative space beneath the logo right now if you scroll to the bottom).

Ideally we'd have a cleaner footer (a la other sunlight pages such as open states). @cweber and I talked about this and she may have suggested a solution that I'm not remembering.

@cweber
Copy link

cweber commented Oct 27, 2016

I don't think I suggested anything in particular, but I do think the original design might have felt a little more like a legit footer. There was less content, it may have had a different background color, and the the map was full screen, which contained the footer in a way that made it feel more unique.

@cweber
Copy link

cweber commented Oct 27, 2016

Actually, looks like the footer was never a different color, but anyway...

If you can figure out how to change to change this line from 10em to 1em ...that's fix the space thing that I think is bothering you.

footer {
padding-bottom: 1em;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants