Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up GitHub Actions #451

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Clean up GitHub Actions #451

merged 4 commits into from
Aug 15, 2024

Conversation

bobbrodie
Copy link
Member

This pull request resolves a few issues that came up in RuboCop:

  • RSpec/ExpectInLet
  • Call super without arguments and parentheses when the signature is identical
  • Use 'add_dependency' instead of 'add_runtime_dependency'

I've also removed the outdated example files, since there are examples in the readme and will update the wiki.

@bobbrodie bobbrodie merged commit b943aee into sumoheavy:master Aug 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-maguire p-maguire p-maguire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobbrodie @p-maguire