Send the syncFactor before the data #428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is quite possible I totally misunderstood how to properly use this library, but I suspect there was a mistake there: the sync bits were not sent on the first repetition of the data and were appended at the end of the packet. It probably still worked as long as repeat >1 and that there is not interference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is quite possible I totally misunderstood how to properly use this library, but I suspect there was a mistake there: the sync bits were not sent on the first repetition of the data and were appended at the end of the packet. It probably still worked as long as repeat >1 and that there is not interference.
See on the this image (captured with
gqrx) on the top line is the command I am trying to duplicate and on the bottom the output fromrc-switch. Once I made the change linked here, the shapes matched.