-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: sp1-lib
, syscall docs
#1189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactor the
sp1-lib
crate inzkvm
, and add testing for theecdsa-core
patch fork256
to thepatch-testing
program.Details
sp1-lib
. Create anAffinePoint
trait which is re-used across curves.ecrecover
logic toecdsa-core
patch for maintainability ecdsa v0.16.9 sp1-patches/signatures#2. Note: Decision to refactor these crates was driven by the circular dependency caused when trying to patchk256
.decompress_pubkey
logic from BLS insp1-lib
.Note on SemVer
Includes backwards-incompatible changes in
sp1-lib
, but because it only causes issues for developers who are creating patches for crates themselves withsp1-lib
(which is highly uncommon), we've decided to not update the major version ofsp1-lib
in this release, although that would follow convention.