Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lint to CI #15

Open
westonpace opened this issue Feb 8, 2023 · 1 comment
Open

Add lint to CI #15

westonpace opened this issue Feb 8, 2023 · 1 comment

Comments

@westonpace
Copy link
Member

Required:

cmake_format
clang-format
Some kind of spdx licensing header check

Consider:

clang-tidy
iwyu
@chaojun-zhang
Copy link
Contributor

Is there any preset github action for this that we can refer to?

@chaojun-zhang chaojun-zhang mentioned this issue Mar 3, 2023
Merged
@chaojun-zhang chaojun-zhang mentioned this issue Mar 21, 2023
Merged
westonpace pushed a commit that referenced this issue Mar 22, 2023
@chaojun-zhang
feat(lint): Add files for clang tidy and license check (#37)
4c199bc 
This PR should be the first PR of issue
#15, and then the
second [PR](#30) will
use this for lint check.

- please see https://github.com/apache/skywalking-eyes for license check
- run-clang-tidy.py : a python script used to check cpp project with
clang-tidy

Co-authored-by: chaojun-zhang <[email protected]>
EpsilonPrime pushed a commit to EpsilonPrime/substrait-cpp that referenced this issue Mar 24, 2023
@chaojun-zhang @EpsilonPrime
feat(lint): Add files for clang tidy and license check (substrait-io#37)
af11d93 
This PR should be the first PR of issue
substrait-io#15, and then the
second [PR](substrait-io#30) will
use this for lint check.

- please see https://github.com/apache/skywalking-eyes for license check
- run-clang-tidy.py : a python script used to check cpp project with
clang-tidy

Co-authored-by: chaojun-zhang <[email protected]>
EpsilonPrime pushed a commit to EpsilonPrime/substrait-cpp that referenced this issue May 6, 2023
@chaojun-zhang @EpsilonPrime
feat(lint): Add files for clang tidy and license check (substrait-io#37)
847a07c 
This PR should be the first PR of issue
substrait-io#15, and then the
second [PR](substrait-io#30) will
use this for lint check.

- please see https://github.com/apache/skywalking-eyes for license check
- run-clang-tidy.py : a python script used to check cpp project with
clang-tidy

Co-authored-by: chaojun-zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chaojun-zhang @westonpace