feat: [AUTH-1645] Add additional params to PasswordsSessionReset #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AUTH-1645 Add SessionToken and SessionJWT to `PasswordsSessionResetResponse`
Things to update: Protobuf API - we will need to refresh the Session JWT for them Web-backend Check if we need to add it in account-manager Docs to include the new fields Generate the SDKs to include the fields |
max-stytch
commented
Sep 8, 2023
| @@ -123,8 +123,8 @@ def exchange( | |||
| locale: nil | |||
| ) | |||
| request = { | |||
| intermediate_session_token: intermediate_session_token, | |||
| organization_id: organization_id | |||
| intermediate_session_token:, | |||
There was a problem hiding this comment.
My local version of rubocop prefers this syntax. I tested it out in irb and it looks valid, but I'm not sure why this change is happening now?
maxwellgerber@MacBook-Pro-103 stytch-ruby % irb
irb(main):001:0> foo = 1
=> 1
irb(main):002:0> test = { foo: }
=> {:foo=>1}
|
Obsoleted by #97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional params to the PasswordsSessionReset method and reruns autogen.