Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error if token auth fails #89

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Raise error if token auth fails #89

merged 1 commit into from
Aug 7, 2023

Conversation

logan-stytch
Copy link
Contributor

Defines two new errors (JWTExpiredError and TokenMissingScopeError) that extend StandardError
Raises in authenticate_token instead of returning nil to protect against cases where someone may use authentication in a guard without actually checking the return value

@logan-stytch logan-stytch requested a review from a team as a code owner August 7, 2023 21:32
max-stytch
max-stytch approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@max-stytch max-stytch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@logan-stytch logan-stytch merged commit 94660b9 into main Aug 7, 2023
3 checks passed
@logan-stytch logan-stytch deleted the logan/m2m branch August 7, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-stytch max-stytch max-stytch approved these changes

@ollie-stytch ollie-stytch Awaiting requested review from ollie-stytch ollie-stytch is a code owner automatically assigned from stytchauth/client-libraries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@logan-stytch @max-stytch