Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control System Fault tracking #31

Open
xortive opened this issue Oct 27, 2015 · 10 comments
Open

Control System Fault tracking #31

xortive opened this issue Oct 27, 2015 · 10 comments
Assignees
Labels

Comments

@xortive
Copy link

xortive commented Oct 27, 2015

Control system components that communicate over CAN such as the PDB, PCM, TalonSRX/Jaguar all have faults and sticky faults. There is no central polling mechanism implemented by WPILib, so we should use EventRecorder in each component to track faults.

@rhauch
Copy link
Member

rhauch commented Oct 27, 2015

We probably want to make recording these faults optional, since the extra logic to poll all of these faults will end up being not trivial, and people may want to turn them off if they can be accessed elsewhere.

@rhauch
Copy link
Member

rhauch commented Oct 27, 2015

The PneumaticsModule interface already defines a pattern for named faults, how they are sticky, and how the sticky faults are cleared. Other components will have different types of faults, but hopefully we can reuse the same pattern.

@xortive
Copy link
Author

xortive commented Oct 27, 2015

The idea of an actual hasFaults interface seems useful to me... you don't
have to remember that PneumaticModule uses compressorFaults(), you have
a common interface and you just can call faults() and stickyFaults() on
any class that implements hasFaults

I'll take a look at this sometime this week, but tonight and tomorrow I'm swamped with homework.

@xortive
Copy link
Author

xortive commented Oct 27, 2015

@rhauch Can you assign this issue to me? I don't have privileges to do so.

@rhauch
Copy link
Member

rhauch commented Oct 27, 2015

@granjef3, it is now assigned to you. Thanks!

@xortive
Copy link
Author

xortive commented Oct 28, 2015

@rhauch Just curious, how do you setup your workspace in eclipse for strongback development? should each folder like strongback, strongback-tests be separate projects in eclipse?

The way I did it, I created a blank .project in the strongback-java folder (same level as build-common.xml) and imported that into eclipse.

@rhauch
Copy link
Member

rhauch commented Oct 28, 2015

@granjef3, well, I just create a new workspace in the strongback-java directory, and then import the existing projects. Also, the ide-config folder contains some Java templates, formatter, and cleanup preferences that you can import to help standardize the auto-formatting in Eclipse.

@rhauch rhauch added this to the Release 1.1.0 milestone Oct 28, 2015
@rhauch
Copy link
Member

rhauch commented Nov 15, 2015

@granjef3, any progress on this issue? If you have code that is not done, you can still create a pull-request and just denote in the PR description that it's incomplete.

@xortive
Copy link
Author

xortive commented Nov 15, 2015

I've been busy with my birthday celebrations. I will try to work on the code this week, sorry about the delay.

Sent from my iPhone

On Nov 15, 2015, at 3:53 PM, Randall Hauch [email protected] wrote:

@granjef3, any progress on this issue? If you have code that is not done, you can still create a pull-request and just denote in the PR description that it's incomplete.


Reply to this email directly or view it on GitHub.

@rhauch
Copy link
Member

rhauch commented Nov 15, 2015

@granjef3, well Happy Birthday! We'd like to release 1.1.0 later this week, after #40 (expose PID control for Talon SRX) is done.

@rhauch rhauch modified the milestones: 2.0.0, Release 1.1.0 Dec 19, 2016
@rhauch rhauch modified the milestones: 2017.2.0, 2017.1.0 Jan 3, 2017
CarlinWilliamson pushed a commit to Team3132/strongback-java that referenced this issue Jun 30, 2020
Change the source for the beam breaks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants