Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The payment sheets flickers when closing iOS 18 Beta 8 #1723

Open
aziryasin opened this issue Sep 3, 2024 · 9 comments
Open

The payment sheets flickers when closing iOS 18 Beta 8 #1723

aziryasin opened this issue Sep 3, 2024 · 9 comments

Comments

@aziryasin
Copy link

Describe the bug
When closing the payment sheet or dismissing it by pressing outside the modal, the sheet closed and pop ups again and then closes.

To Reproduce
Steps to reproduce the behavior:

  1. initPaymentSheet
  2. Open payment sheet using presentPaymentSheet
  3. Close or press outside the sheet to dismiss
  4. See the flickering

Expected behavior
The sheet should be closed without flickering

Screenshots
https://github.com/user-attachments/assets/05715492-a17c-4d0c-9fb0-4004d279bfd1

Smartphone:

  • Device: [e.g. iPhone6] iPhone SE 3rd Generation
  • OS: iOS 18 Beta 8
  • Version
    stripe-react-native v0.38.4
    react-native v0.70.8

Additional context
Only happening in iOS 18

@kele-leanes
Copy link

same issue

@nicolasdevienne
Copy link

same issue when user confirm the payment

@Ortbri
Copy link

Ortbri commented Sep 20, 2024

same here too, i was actually having the issue on IOS 17.6.1. and on IOS 18. The flicker is for sure there. It works on simulator for both IOS and Android on my side. Just physical devices give me the issue.

@mikkoseppa
Copy link

Same issue here. Confirmed happening on iOS 18.0, and confirmed it's still present on iOS 18.1 beta 4. Our team would really appreciate someone taking a look into it since it downgrades the customer experience of our production application, thank you!

@yuki-stripe
Copy link
Collaborator

Thanks for reporting this. Can you provide logs when the dismiss happens? It seems like an autolayout constraint is breaking.

@mikkoseppa
Copy link

Thanks for reporting this. Can you provide logs when the dismiss happens? It seems like an autolayout constraint is breaking.

This is the only log entry when I dismiss. Nothing about autolayout / constraint errors.
LOG ANALYTICS: mc_dismiss - [(key: "pay_var", value: "legacy"), (key: "ocr_type", value: "none"), (key: "apple_pay_enabled", value: 1)]

I also checked the "Debug view hierarchy" in Xcode for any runtime constraint warnings, and there is nothing meaningful for this issue.

@yuki-stripe
Copy link
Collaborator

Hrmm thank you. I can't repro on iOS 18 & Xcode 16, simulator or device. We'll need to try React Native; I can't see anything in the React Native SDK that would cause this, though (eg this code)

There's an similar animation glitch that can occur on iOS 18 when a TextField takes focus when PaymentSheet dismisses and the keyboard is toggled (eg "Toggle Software Keyboard" in the simulator), but that doesn't seem to be happening here.

@hot2eatorg
Copy link

hot2eatorg commented Oct 5, 2024

Same issue here. Breaks on iOS 18. Same code works fine without the flickering on iOS 17.4 Both compiled using Xcode 16

   "expo": "~50.0.14",
   "@stripe/stripe-react-native": "^0.38.6",
   "react-native": "0.73.6",
  • Simulator for iOS 18: iPhone 16 Pro
  • Simulator for iOS 17.4 iPhone 15 Pro

I haven't tested it in a real device yet.

@stalkerlifehack
Copy link

stalkerlifehack commented Oct 7, 2024

Same issue,
On real device (iPhone 15 Pro Max) with iOS 17 is ok, but iOS 18 have problem.

"@stripe/stripe-react-native": "^0.37.0",
"react-native": "0.73.4",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants