Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ISK currency formatting #3987

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

Thithip
Copy link
Contributor

@Thithip Thithip commented Sep 5, 2024

Summary

When processing a payment in ISK (Iceland) currency, the amount displayed on the Stripe Widget is wrong by adding two extra zeros.
This PR add a special case for the ISK currency.

Motivation

Resolves #3986

Testing

Add a test case in the test file NSString+StripeTest

Changelog

@Thithip Thithip requested review from a team as code owners September 5, 2024 14:12
@CLAassistant
Copy link

CLAassistant commented Sep 5, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@davidme-stripe
Copy link
Contributor

davidme-stripe commented Sep 23, 2024

Thanks for fixing this! Sorry for the delay, we'll get this merged.

@Thithip
Copy link
Contributor Author

Thithip commented Sep 24, 2024

Thank you David :)

@davidme-stripe davidme-stripe merged commit ad466eb into stripe:master Sep 24, 2024
4 checks passed
davidme-stripe added a commit that referenced this pull request Sep 24, 2024
## Summary
Add changelog entry for #3987

## Testing
👀
@Thithip Thithip deleted the fix/isk_currency_rendering branch September 25, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ISK formatting issue
3 participants