Add App components #102
Merged
Add App components #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgea-stripe
requested changes
Jul 24, 2024
| @@ -49,7 +49,7 @@ | |||
| "@babel/preset-react": "7.18.6", | |||
| "@rollup/plugin-json": "^6.0.0", | |||
| "@rollup/plugin-replace": "^2.3.1", | |||
| "@stripe/connect-js": "3.3.11-beta-1", | |||
There was a problem hiding this comment.
Can you also bump the peerDependencies below to this same number?
src/Components.tsx
Outdated
| onAppInstallStateChange, | ||
| }: { | ||
| app: string; | ||
| onAppInstallStateFetch: () => void; |
There was a problem hiding this comment.
I think this is missing the actual values to callback right (as in the state of the installed app)?
jorgea-stripe
approved these changes
Jul 27, 2024
| onAppInstallStateChange, | ||
| }: { | ||
| app: string; | ||
| onAppInstallStateFetch?: (({appId, state}: InstallState) => void) | undefined; |
There was a problem hiding this comment.
I don't think you need the | undefined here, since the property is already optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Review: https://docs.google.com/document/d/1WSZBpaLvJLDmhaA3VMTpV3cYvaZ920gWDBNX0dKMXrA/edit#heading=h.nbrl5773k5jx
connect-js changes: stripe/connect-js#137
Tested on connect-test