Bump version of Connect-JS #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgea-stripe
approved these changes
Jul 17, 2024
jorgea-stripe
requested changes
Jul 17, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@stripe/react-connect-js", | |||
| "version": "3.3.9", | |||
| "version": "3.3.10", | |||
There was a problem hiding this comment.
Why is this bumped in this PR? This should be bumped during publishing only
There was a problem hiding this comment.
This should have been bumped last time it seems. React-Connect-JS is currently published as 3.3.10.
There was a problem hiding this comment.
Let's bump it in a separate PR
| @@ -84,7 +84,7 @@ | |||
| "zx": "^4.2.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "@stripe/connect-js": ">=3.3.9", | |||
| "@stripe/connect-js": ">=3.3.10", | |||
There was a problem hiding this comment.
If we bump this, we also need to bump dependencies
There was a problem hiding this comment.
Connect-JS is published as 3.3.10. I think the react-connect-js was not updated correctly, causing this issue https://stripe.slack.com/archives/C02Q96U5F4Z/p1721239186533239 .
|
Closing, doesn't seem like this was the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped version to fix dependency issues.