Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom Depth Test Function for Materials #2415

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Eideren
Copy link
Collaborator

@Eideren Eideren commented Aug 16, 2024

PR Details

Provides the ability for users to set custom depth testing functions per material for special effects
image
Here, a sphere clipped into another sphere by using the Greater depth function
image
image
This is often used for bullet impacts, selections in RTS, previews in level editors ...

Related Issue

None afaict.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren changed the title [Graphics] Custom Depth Test Function for Materials feat: Custom Depth Test Function for Materials Aug 16, 2024
Copy link
Contributor

@Doprez Doprez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an exciting addition, this could be used to improve https://github.com/profan/XenkoByteSized?tab=readme-ov-file#xenkobytesizedproceduralmeshsubdividedplanemesh with some visual feedback.

I don't see any concerns other than a few small typos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants