Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo up to the LIB does not work #37

Open
sduchesneau opened this issue Feb 19, 2024 · 0 comments
Open

Undo up to the LIB does not work #37

sduchesneau opened this issue Feb 19, 2024 · 0 comments
Assignees

Comments

@sduchesneau
Copy link
Contributor

2024-02-19T14:54:30.097Z ERRO (sink-kv) buffer undo block: cannot undo down to last valid Block #249162326 (5uaFaxM8JENWi38Kf6xdWcSK1B56YmQ69ccepuDqFYeS) because we already sent you Block #249162348 (tSHqPkLcDMtXRVQu3U7KULAWTsZer4PA9miQGLqKcCz) which is after last valid block

The kv sink should handle undoing up to the lib, this is probably an off-by-one error.

Also, the error message is confusing.
"Cannot undo down to last valid block 249162326" -> it is not because we sent block 249162348... presumably, it's because the undo data has been truncated to "above 249162326". fix the error message too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants