feat: add useSignallingEffect for idiomatic side-effect cancellation #2546
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
useSignallingEffect
runs an effect with anAbortSignal
, which is automatically aborted when the effect is cleaned up. This provides an idiomatic way of cancelling side-effects.Useful as a shorthand for common operations that require clean up or cancellation and support
AbortSignal
, like adding event listeners:Or fetching data:
Type of change
Checklist
yarn test
)yarn lint
). Fix it withyarn lint:fix
in case of failure.yarn lint:types
).Note: there's an expected
exhaustive-deps
eslint rule violation, which is inherent to alluseEffect
-style hooks. I didn't ignore it with a comment since other hooks don't do that.