Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some dependencies to peerDependencies to use them in different applications #2565

Open
meluiz opened this issue Jul 4, 2024 · 2 comments

Comments

@meluiz
Copy link

meluiz commented Jul 4, 2024

What is the current behavior?
I am currently receiving an error when using react-use in React Native applications.

Steps to reproduce it and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have extra dependencies other than react-use. Paste the link to your JSFiddle or CodeSandbox example below:

  1. yarn add react-use
  2. yarn start

What is the expected behavior?

It is expected that some hooks, which rely exclusively on the browser to run, should treat their dependencies as peerDependencies and make it optional to download them for use.

An example I can mention is useCss, which depends on nano-css. Even if I don't use useCss in the React Native application, I receive an error due to the nano-css dependency, where there is a check for a global variable that does not exist in a mobile environment.

A little about versions:

  • OS: macOs Sonoma v14.5
  • Browser (vendor and version):
  • React: v18.2.0
  • react-use: v17.5.0
  • Did this worked in the previous package version?
@mrtawil
Copy link

mrtawil commented Jul 10, 2024

+1

1 similar comment
@pranshuchittora
Copy link

pranshuchittora commented Jul 25, 2024

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants