Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(volume): add support of O_SYMLINK #944

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

uhyo
Copy link
Contributor

@uhyo uhyo commented Aug 19, 2023

In Node.js, you can get a file descriptor for a symlink itself, not the file referred to by it. This can be achieved by passing O_SYMLINK to fs.open.

This PR adds support of O_SYMLINK for better compatibility. It includes following changes:

  • Definition of O_SYMLINK in constants.
  • Converts O_SYMLINK flag to resolveSymlinks.
  • Throws error when one attemps to read or write to a file descriptor for symlinks.

@G-Rath G-Rath merged commit 96cbce4 into streamich:master Sep 15, 2023
9 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 15, 2023
# [4.3.0](v4.2.3...v4.3.0) (2023-09-15)

### Features

* add support for `O_SYMLINK` ([#944](#944)) ([96cbce4](96cbce4))
@streamich
Copy link
Owner

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@uhyo uhyo deleted the o-symlink branch September 16, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants