-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lib versioning script #1114
Merged
plebhash
merged 2 commits into
stratum-mining:dev
from
plebhash:rm-lib-versioning-script
Aug 19, 2024
Merged
Remove lib versioning script #1114
plebhash
merged 2 commits into
stratum-mining:dev
from
plebhash:rm-lib-versioning-script
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitGab19
approved these changes
Aug 19, 2024
Bencher
🚨 2 ALERTS: Threshold Boundary Limits exceeded!
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
plebhash
force-pushed
the
rm-lib-versioning-script
branch
from
August 19, 2024 19:33
e50da12
to
a1ba348
Compare
plebhash
force-pushed
the
rm-lib-versioning-script
branch
from
August 19, 2024 19:35
a1ba348
to
b3dde39
Compare
plebhash
changed the title
Remove lib versioning script + set SemVer safeguards to
Remove lib versioning script
Aug 19, 2024
release-libs.yaml
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ever since we merged #985, we now have a CI fully dedicated to enforcing SemVer for all PRs against
dev
andmain
that essentially makes
scripts/check-versioning-lib-release.sh
obsolete, so it is being removed via f883bdehowever, the failure of this script was a safeguard that would prevent any libs from being published to
crates.io
if we only removed the script, that would still leave the possibility of publishing crates that failed SemVer CI, which is undesirable
so b3dde39 is making sure
release-libs
only runs if the PR tomain
was actually merged