Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fmt an clippy as git hook for commit #1073

Closed
Fi3 opened this issue Jul 26, 2024 · 5 comments
Closed

Add fmt an clippy as git hook for commit #1073

Fi3 opened this issue Jul 26, 2024 · 5 comments
Labels
backlog Not necessary, but worth tracking good first issue Good for newcomers

Comments

@Fi3
Copy link
Collaborator

Fi3 commented Jul 26, 2024

Before committing is very useful to always have fmt and clippy executed so we avoid to have the git log full of fmt and clippy and git blame is more likely to point to the right commit.

@Fi3 Fi3 added good first issue Good for newcomers backlog Not necessary, but worth tracking labels Jul 26, 2024
@xyephy
Copy link
Contributor

xyephy commented Aug 12, 2024

@Fi3 Should I place the pre-commit file under the .githooks directory?

@xyephy
Copy link
Contributor

xyephy commented Aug 12, 2024

@Fi3 Should I place the pre-commit file under the .githooks directory?

I'm also getting some errors related to #1048

@Shourya742
Copy link
Contributor

Hey @xyephy, there’s already an ongoing PR for this issue: #1039

@xyephy
Copy link
Contributor

xyephy commented Aug 12, 2024

Hey @xyephy, there’s already an ongoing PR for this issue: #1039

Thanks for the heads up @Shourya742 , will have a look at it.

@GitGab19
Copy link
Collaborator

GitGab19 commented Sep 4, 2024

Closing this as addressed by #1039

@GitGab19 GitGab19 closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Not necessary, but worth tracking good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants