Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBD/Rewind] Optimize VotingManager for batched operations #933

Open
wants to merge 7 commits into
base: release/1.6.0.0
Choose a base branch
from

Conversation

quantumagi
Copy link
Contributor

@quantumagi quantumagi commented Mar 13, 2022

https://app.clickup.com/t/20r2acb

Addresses the following:

        "BlockConnected" average total execution time: 15.6064 ms.
            ReserveUtxoService.OnBlockConnected-------------------------0.0038 ms---0 %
            MempoolSignaled.OnBlockConnected----------------------------0.0033 ms---0 %
            WalletSyncManager.OnBlockConnected--------------------------0.0013 ms---0 %
            BlockStoreSignaled.OnBlockConnected-------------------------0.0133 ms---0 %
            EventSubscriptionService.<Init>g__callback|6_0--------------0.1138 ms---1 %
            VotingManager.OnBlockConnected------------------------------15.4709 ms--99 %

By allowing the VM to lag during IBD we can move away from the current scenario of only processing one block at a time (and committing to the DB each time). Decreasing the number of commits cuts hours off the IBD process.

@quantumagi quantumagi changed the base branch from release/1.3.0.0 to release/1.4.0.0 March 21, 2022 12:47
@quantumagi quantumagi marked this pull request as draft May 1, 2022 12:40
@fassadlr fassadlr changed the base branch from release/1.4.0.0 to release/1.5.0.0 October 21, 2022 12:43
@fassadlr fassadlr added 1.6.0.0 and removed 1.4.0.0 labels Oct 21, 2022
@quantumagi quantumagi marked this pull request as ready for review November 8, 2022 08:11
@quantumagi quantumagi marked this pull request as draft November 8, 2022 08:17
@quantumagi quantumagi removed the request for review from fassadlr November 9, 2022 09:11
@quantumagi quantumagi marked this pull request as ready for review November 9, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants