Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetHistory API returns incorrect values for transactions to two addresses in the same wallet - updated for 1.1.0.0 #390

Open
0tim0 opened this issue Jan 20, 2021 · 3 comments

Comments

@0tim0
Copy link
Contributor

0tim0 commented Jan 20, 2021

Using /api/Wallet/history (Cirrus Full Node 1.0.6.4) returned incorrect values for some transactions. These transactions turned out to be ones where the transaction was one like https://cirrusexplorer.stratisplatform.com/transactions/00b4cfead03ab2bda66738c3fe0fbfbb422def725f448c518647075704e826ca where two addresses from the same wallet received funds in the same transaction (in this case they also had the same amount - this might be caused by excess deduplication).
Previously (in 1.0.4.2), the total amount for both lines was returned, now only the amount for one line was returned. The difference was first seen in 1.0.5

*** After further testing, this issue appears between 1.0.4.3 and 1.0.4.4

@atiq-cs
Copy link

atiq-cs commented Jul 10, 2021

Does it repro on '1.0.9.0'?

@0tim0
Copy link
Contributor Author

0tim0 commented Nov 29, 2021

I'm seeing a similar issue on Cirrus Core 1.6.0 (FN 1.0.9.5). It happens when I send a payment from Cirrus address A to Cirrus address B where A and B are in the same wallet and there is change returning to A (i.e. 100.0001 from A --> 70 to B, 30 to A, 0.0001 to fees).
In address A I don't see either line of this transaction (either in Cirrus Core or via /api/Wallet/history directly). I was expecting to see either [-100.0001 then +30] or [-70.0001].
In address B I see +70 as expected. https://chainz.cryptoid.info/cirrus shows the correct transactions for both A and B

@0tim0 0tim0 changed the title GetHistory API returns incorrect values for transactions to two addresses in the same wallet GetHistory API returns incorrect values for transactions to two addresses in the same wallet - updated for 1.0.9.5 Nov 29, 2021
@0tim0 0tim0 changed the title GetHistory API returns incorrect values for transactions to two addresses in the same wallet - updated for 1.0.9.5 GetHistory API returns incorrect values for transactions to two addresses in the same wallet - updated for 1.1.0.0 Dec 2, 2021
@0tim0
Copy link
Contributor Author

0tim0 commented Dec 2, 2021

After update to 1.1.0.0, confirmed that the API still doesn't return the send transaction on this address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants